Skip to content

Translate Conditional Rendering - #92

Merged
resir014 merged 3 commits into
reactjs:masterfrom
andriawan:conditional-rendering
Oct 26, 2019
Merged

Translate Conditional Rendering#92
resir014 merged 3 commits into
reactjs:masterfrom
andriawan:conditional-rendering

Conversation

@andriawan

Copy link
Copy Markdown
Contributor

Dear Maintainers, i propose PR in Translating Conditional Rendering. Please review this work and give me feedback. Thank you for giving me chance to join this project.

@netlify

netlifyBot commented Jul 14, 2019

Copy link
Copy Markdown

Deploy preview for idreactjs ready!

Built with commit 5d50927

https://deploy-preview-92--idreactjs.netlify.com

@netlify

netlifyBot commented Jul 14, 2019

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit c6bab94

https://deploy-preview-92--id-reactjs.netlify.com

@netlify

netlifyBot commented Jul 14, 2019

Copy link
Copy Markdown

Deploy preview for id-reactjs ready!

Built with commit 5d50927

https://deploy-preview-92--id-reactjs.netlify.com

@grikomsngrikomsn self-assigned this Jul 15, 2019

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ada beberapa poin sedikit yang perlu di-addres sebelum PR ini dapat di-merge. Thanks sebelumnya!

Comment threadcontent/docs/conditional-rendering.md
Comment threadcontent/docs/conditional-rendering.md
Comment threadcontent/docs/conditional-rendering.md
Comment threadcontent/docs/conditional-rendering.md

@grikomsngrikomsn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most are minor typos which can be commited using the suggestion, but some must be discussed further related to usage of merender or dirender and other phrasings.

Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
@grikomsn

Copy link
Copy Markdown

Hello there, @andriawan. Please check the discussion and commit suggestions, since others cannot make changes to your branch unless you allow edits from maintainers. Thanks in advance. 😄

@andriawan

Copy link
Copy Markdown
ContributorAuthor

Sorry for pending response for the feedback. Anyway, thanks for giving me the feedback. i will propose commit with suggestions. Could you give me clue in allowing edits my branch @grikomsn ?

Hello there, @andriawan. Please check the discussion and commit suggestions, since others cannot make changes to your branch unless you allow edits from maintainers. Thanks in advance. 😄

@grikomsn

Copy link
Copy Markdown

Open this PR, look below the "Lock conversation" and there should be a checkbox to allow edits from maintainers. Check that and other maintainers can edit too for quicker revisions. 😄

image

@andriawan

Copy link
Copy Markdown
ContributorAuthor

test

i think it has already done...

@grikomsn

Copy link
Copy Markdown

Yet somehow I cannot apply commit suggestions. Looks like you should apply revisions yourself for now. 😅

image

@resir014, any ideas about this?

@andriawan

Copy link
Copy Markdown
ContributorAuthor

Dear maintainers, could I have some feedback? @grikomsn

@andriawan

Copy link
Copy Markdown
ContributorAuthor

does it need any further improvement? @grikomsn

@resir014resir014 assigned resir014 and unassigned grikomsnOct 23, 2019
@resir014
resir014 merged commit 444a55d into reactjs:masterOct 26, 2019
@andriawan
andriawan deleted the conditional-rendering branch February 10, 2020 08:19
@resir014resir014 mentioned this pull request May 1, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@andriawan@grikomsn@resir014