Skip to content

docs: translate tutorial: tic tac toe - #437

Merged
deblasis merged 9 commits into
reactjs:mainfrom
mattia-sanfilippo:translate-tutorial-tic-tac-toe
May 28, 2023
Merged

docs: translate tutorial: tic tac toe#437
deblasis merged 9 commits into
reactjs:mainfrom
mattia-sanfilippo:translate-tutorial-tic-tac-toe

Conversation

@mattia-sanfilippo

@mattia-sanfilippomattia-sanfilippo commented May 2, 2023

Copy link
Copy Markdown
Collaborator

Translate "Tutorial: Tic Tac Toe"

Part of #418

@github-actions

github-actionsBot commented May 2, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Ago95Dev
Ago95Dev reviewed May 21, 2023
View reviewed changes

@Ago95DevAgo95Dev left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao Mattia! 😄

Ho provato a scrivere una review, magari è di aiuto 🙂

Comment threadsrc/content/learn/tutorial-tic-tac-toe.md Outdated
Comment threadsrc/content/learn/tutorial-tic-tac-toe.md Outdated
Comment threadsrc/content/learn/tutorial-tic-tac-toe.md Outdated
Comment threadsrc/content/learn/tutorial-tic-tac-toe.md Outdated
Comment threadsrc/content/learn/tutorial-tic-tac-toe.md Outdated
Comment threadsrc/content/learn/tutorial-tic-tac-toe.md Outdated
Comment threadsrc/content/learn/tutorial-tic-tac-toe.md Outdated
```

Finally, you will modify the `Game` component to render the currently selected move, instead of always rendering the final move:
Infine, modificherai il componente `Gioco` per eseguire il rendering della mossa attualmente selezionata, invece di eseguire sempre il rendering della mossa finale:

@Ago95DevAgo95DevMay 21, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Infine, modificherai il componente `Gioco` per eseguire il rendering della mossa attualmente selezionata, invece di eseguire sempre il rendering della mossa finale:
Infine, modificherai il componente `Game` per eseguire il rendering della mossa attualmente selezionata, invece di eseguire sempre la renderizzazione della mossa finale:

Comment threadsrc/content/learn/tutorial-tic-tac-toe.md
```

Next, you will need to pass that `i` to `handleClick`. You could try to set the `onSquareClick` prop of square to be `handleClick(0)` directly in the JSX like this, but it won't work:
Successivamente, dovrai passare quella `i` a `handleClick`. Potresti provare a impostare la prop `onSquareClick` di square in modo che sia `handleClick(0)` direttamente nel JSX in questo modo, ma non funzionerà:

@Ago95DevAgo95DevMay 21, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Successivamente, dovrai passare quella `i` a `handleClick`. Potresti provare a impostare la prop `onSquareClick` di square in modo che sia `handleClick(0)` direttamente nel JSX in questo modo, ma non funzionerà:
Successivamente, dovrai passare quella `i` a `handleClick`. Potresti provare a impostare la prop `onSquareClick` di Square in modo che sia `handleClick(0)` direttamente nel JSX in questo modo, ma non funzionerà:

@mattia-sanfilippomattia-sanfilippoMay 23, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao @Ago95Dev, su questo non sono sicuro, terrei lo stesso casing della versione originale. Cosa ne pensi? :)

@Ago95DevAgo95DevMay 23, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non ho capito il minuscolo nell'originale, riferito a Square nell'esempio sotto 😅

In ogni caso, sono d'accordo, meglio lasciare lo stesso casing per coerenza 😃

mattia-sanfilippoand others added 6 commits May 23, 2023 11:38
@mattia-sanfilippo@Ago95Dev
Update src/content/learn/tutorial-tic-tac-toe.md
a81f929
Co-authored-by: Agostino D'Agostino <agostino.dagostino.developer@gmail.com>
@mattia-sanfilippo@Ago95Dev
Update src/content/learn/tutorial-tic-tac-toe.md
49fc2b9
Co-authored-by: Agostino D'Agostino <agostino.dagostino.developer@gmail.com>
@mattia-sanfilippo@Ago95Dev
Update src/content/learn/tutorial-tic-tac-toe.md
34c25f8
Co-authored-by: Agostino D'Agostino <agostino.dagostino.developer@gmail.com>
@mattia-sanfilippo@Ago95Dev
Update src/content/learn/tutorial-tic-tac-toe.md
85a32f9
Co-authored-by: Agostino D'Agostino <agostino.dagostino.developer@gmail.com>
@mattia-sanfilippo@Ago95Dev
Update src/content/learn/tutorial-tic-tac-toe.md
4c24b67
Co-authored-by: Agostino D'Agostino <agostino.dagostino.developer@gmail.com>
@mattia-sanfilippo@Ago95Dev
Update src/content/learn/tutorial-tic-tac-toe.md
5cef7a9
Co-authored-by: Agostino D'Agostino <agostino.dagostino.developer@gmail.com>
@mattia-sanfilippo

mattia-sanfilippo commented May 23, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Ciao Mattia! 😄

Ho provato a scrivere una review, magari è di aiuto 🙂

Ciao Agostino 😄 Grazie mille per le suggestions!
Le ho applicate, eccetto una per via di un cambio di casing. Grazie ancora :)

deblasis
deblasis approved these changes May 28, 2023
View reviewed changes

@deblasisdeblasis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@deblasis
deblasis merged commit db218bf into reactjs:mainMay 28, 2023
@deblasisdeblasis mentioned this pull request May 28, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deblasisdeblasisdeblasis approved these changes
+1 more reviewer
@Ago95DevAgo95DevAgo95Dev left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattia-sanfilippo@deblasis@Ago95Dev