Skip to content

Translate integrating-with-other-libraries - #117

Merged
smikitky merged 1 commit into
reactjs:masterfrom
thayashi:tr/integrating-with-other-libraries
Feb 18, 2019
Merged

Translate integrating-with-other-libraries#117
smikitky merged 1 commit into
reactjs:masterfrom
thayashi:tr/integrating-with-other-libraries

Conversation

@thayashi

@thayashithayashi commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

This PR is part of Issue #4.

@thayashithayashi reopened this Feb 12, 2019
@thayashi
thayashiforce-pushed the tr/integrating-with-other-libraries branch from 9d8dde4 to 86370eaCompareFebruary 12, 2019 23:12
@thayashi

thayashi commented Feb 12, 2019

Copy link
Copy Markdown
ContributorAuthor

How I can assign @smikitky as a reviewer?

@smikitky
smikitky self-requested a review February 13, 2019 03:06
@smikitky

smikitky commented Feb 13, 2019

Copy link
Copy Markdown
Member

Sorry, that was possible for someone with write access. Edited the instruction.

@smikitkysmikitky added the 🚫 in intial review 初期レビューの真っ最中 label Feb 13, 2019
smikitky
smikitky requested changes Feb 13, 2019
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューしました。大部分は訳語統一や軽微な誤字になりますのでご確認いただけますでしょうか。

Comment threadcontent/docs/integrating-with-other-libraries.md
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
@smikitkysmikitky removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 13, 2019
@tesseralistesseralis mentioned this pull request Feb 13, 2019
Closed
90 tasks
@thayashi
thayashiforce-pushed the tr/integrating-with-other-libraries branch from 86370ea to 3bfde13CompareFebruary 13, 2019 18:19
@thayashi

thayashi commented Feb 13, 2019

Copy link
Copy Markdown
ContributorAuthor

@smikitky レビューありがとうございました。もろもろ修正しましたのでご確認ください。

potato4d
potato4d approved these changes Feb 16, 2019
View reviewed changes

@potato4dpotato4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうに見えます

@thayashi
thayashiforce-pushed the tr/integrating-with-other-libraries branch from 6bb94e7 to 527e116CompareFebruary 16, 2019 20:41
smikitky
smikitky requested changes Feb 18, 2019
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません1か所だけミスを見つけました

Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
@thayashi
thayashiforce-pushed the tr/integrating-with-other-libraries branch from 527e116 to 05c7ac3CompareFebruary 18, 2019 17:21
@smikitky
smikitky merged commit ff9b6aa into reactjs:masterFeb 18, 2019
@smikitky

smikitky commented Feb 18, 2019

Copy link
Copy Markdown
Member

ありがとうございました！

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smikitkysmikitkysmikitky approved these changes
+1 more reviewer
@potato4dpotato4dpotato4d approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thayashi@smikitky@potato4d