Skip to content

Translate dom-elements - #12

Merged
smikitky merged 12 commits into
reactjs:masterfrom
kn3ny:dom-elements-ja
Feb 3, 2019
Merged

Translate dom-elements#12
smikitky merged 12 commits into
reactjs:masterfrom
kn3ny:dom-elements-ja

Conversation

@kn3ny

@kn3nykn3ny commented Feb 1, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Related Issue: #4
Translation of https://reactjs.org/docs/dom-elements.html

  • crowdinの翻訳を適用
  • 未翻訳部分を翻訳
  • crowdinで既に翻訳されていた部分で、少し違和感がある部分の修正

@smikitky

smikitky commented Feb 2, 2019

Copy link
Copy Markdown
Member

準備ができたところで呼んでくださいませ

@kn3nykn3ny changed the title WIP: Translate dom-elementsTranslate dom-elementsFeb 2, 2019
@kn3ny

kn3ny commented Feb 2, 2019

Copy link
Copy Markdown
ContributorAuthor

@smikitky ありがとうございます！翻訳終わりましたので、レビューをお願いします 🙇

@smikitky
smikitky self-requested a review February 2, 2019 09:09
smikitky
smikitky requested changes Feb 2, 2019
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

幾つか対応をお願いします。

Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
Comment threadcontent/docs/reference-dom-elements.md Outdated
smikitkyand others added 7 commits February 2, 2019 19:09
@smikitky@kn3ny
Update content/docs/reference-dom-elements.md
c29100c
Co-Authored-By: kn3ny <30493783+kn3ny@users.noreply.github.com>
@smikitky@kn3ny
Update content/docs/reference-dom-elements.md
a86f619
Co-Authored-By: kn3ny <30493783+kn3ny@users.noreply.github.com>
@smikitky@kn3ny
Update content/docs/reference-dom-elements.md
11f0e7d
Co-Authored-By: kn3ny <30493783+kn3ny@users.noreply.github.com>
@smikitky@kn3ny
Update content/docs/reference-dom-elements.md
48d40a7
Co-Authored-By: kn3ny <30493783+kn3ny@users.noreply.github.com>
@smikitky@kn3ny
Update content/docs/reference-dom-elements.md
6db0adf
Co-Authored-By: kn3ny <30493783+kn3ny@users.noreply.github.com>
@smikitky@kn3ny
Update content/docs/reference-dom-elements.md
d5bd8d7
Co-Authored-By: kn3ny <30493783+kn3ny@users.noreply.github.com>
@kn3ny
Update content/docs/reference-dom-elements.md
72a1139
@kn3ny

kn3ny commented Feb 2, 2019

Copy link
Copy Markdown
ContributorAuthor

@smikitky レビュー＆パッチありがとうございました。内容を確認して修正しました 👍

@smikitky

smikitky commented Feb 2, 2019

Copy link
Copy Markdown
Member

非常にクオリティの高い翻訳で助かりました！
次回から "Add Suggestion to Batch" の方も使ってみてください

@kn3ny

kn3ny commented Feb 2, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@smikitky レビューお疲れ様です。次回以降はBatch使いますね 🙇

@tesseralistesseralis mentioned this pull request Feb 2, 2019
Closed
90 tasks
@smikitky
smikitky merged commit ac69e0e into reactjs:masterFeb 3, 2019
@kn3ny
kn3ny deleted the dom-elements-ja branch February 4, 2019 02:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smikitkysmikitkysmikitky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kn3ny@smikitky