Skip to content

translate faq-versioning - #121

Merged
potato4d merged 6 commits into
reactjs:masterfrom
37108:faq/versioningPolicy
Feb 16, 2019
Merged

translate faq-versioning#121
potato4d merged 6 commits into
reactjs:masterfrom
37108:faq/versioningPolicy

Conversation

@37108

@3710837108 commented Feb 14, 2019

Copy link
Copy Markdown

related issue: #4
Translation: Versioning Policy

レビューをお願いいたします 🙇

@smikitky
smikitky self-requested a review February 14, 2019 03:39
@smikitkysmikitky added the 🚫 in intial review 初期レビューの真っ最中 label Feb 14, 2019
smikitky
smikitky requested changes Feb 14, 2019
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました。幾つか訳文の修正をお願いしたいところがありますので対応をお願い致します。

Comment threadcontent/docs/faq-versioning.md Outdated
Comment threadcontent/docs/faq-versioning.md Outdated
Comment threadcontent/docs/faq-versioning.md Outdated
Comment threadcontent/docs/faq-versioning.md Outdated
Comment threadcontent/docs/faq-versioning.md Outdated
Comment threadcontent/docs/faq-versioning.md Outdated
Comment threadcontent/docs/faq-versioning.md Outdated
Comment threadcontent/docs/faq-versioning.md Outdated
Comment threadcontent/docs/faq-versioning.md Outdated
Comment threadcontent/docs/faq-versioning.md Outdated
@smikitkysmikitky removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 14, 2019
@37108

37108 commented Feb 14, 2019

Copy link
Copy Markdown
Author

@smikitky

確認しました。幾つか訳文の修正をお願いしたいところがありますので対応をお願い致します。

承知しました。対応させていただきます。レビューありがとうございます。🙇

@tesseralistesseralis mentioned this pull request Feb 14, 2019
Closed
90 tasks
@37108

37108 commented Feb 14, 2019

Copy link
Copy Markdown
Author

レビューに沿っての修正と確認を実施しました。

確認をお願いいたします。 🙇

smikitky
smikitky requested changes Feb 14, 2019
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません、この2点について追加でお願いします m(_ _)m

Comment threadcontent/docs/faq-versioning.md Outdated
Comment threadcontent/docs/faq-versioning.md Outdated
smikitkyand others added 2 commits February 14, 2019 19:45
@smikitky37108
半角スペースの挿入とスペルアウト
79a5585
Co-Authored-By: 37108 <03230@protonmail.com>
@smikitky37108
句点入れ忘れの修正
19c9515
Co-Authored-By: 37108 <03230@protonmail.com>
@37108

37108 commented Feb 14, 2019

Copy link
Copy Markdown
Author

レビューありがとうございます。
2点とも修正しました。

@smikitky

smikitky commented Feb 14, 2019

Copy link
Copy Markdown
Member

ありがとうございました！

potato4d
potato4d approved these changes Feb 16, 2019
View reviewed changes

@potato4dpotato4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうですー！

@potato4d
potato4d merged commit be36711 into reactjs:masterFeb 16, 2019
@potato4d

potato4d commented Feb 16, 2019

Copy link
Copy Markdown
Contributor

#4 には反映済み

@37108

37108 commented Feb 16, 2019

Copy link
Copy Markdown
Author

ご対応ありがとうございました!!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smikitkysmikitkysmikitky approved these changes
+1 more reviewer
@potato4dpotato4dpotato4d approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@37108@smikitky@potato4d