Optimizing performance by uehaj · Pull Request #122 · reactjs/ja.react.dev

uehaj · 2019-02-14T21:52:50Z

This PR is part of Issue #4.
レビューを宜しくお願いします。

smikitky

遅くなりましたが、全体を確認しました。

数が多かったので個別に指摘していませんが、「レンダリング」は「レンダー」で統一でお願いします（名詞として使用される場合も動詞として使用される場合も同じ）。
原文にないところで改行が含まれていたり、逆に原文に存在する空行を消してしまっているところがたくさんあり、GitHubの差分で見ても左右で文章が一致していないところが多くあります。今後原文の翻訳が更新されたときの自動マージに悪影響があるため、改行位置を統一するようお願いします。

Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

netlify · 2019-03-02T10:16:12Z

Deploy preview for ja-reactjs ready!

Built with commit ddf7100

https://deploy-preview-122--ja-reactjs.netlify.com

Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

netlify · 2019-03-02T10:22:59Z

Deploy preview for ja-reactjs ready!

Built with commit 22a0825

https://deploy-preview-122--ja-reactjs.netlify.com

netlify · 2019-03-02T10:28:29Z

Deploy preview for ja-reactjs ready!

Built with commit 1faf91f

https://deploy-preview-122--ja-reactjs.netlify.com

Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

…reactjs.org into optimizing-performance

uehaj · 2019-03-02T13:18:01Z

遅くなりましたが、全体を確認しました。
数が多かったので個別に指摘していませんが、「レンダリング」は「レンダー」で統一でお願いします（名詞として使用される場合も動詞として使用される場合も同じ）。
原文にないところで改行が含まれていたり、逆に原文に存在する空行を消してしまっているところがたくさんあり、GitHubの差分で見ても左右で文章が一致していないところが多くあります。今後原文の翻訳が更新されたときの自動マージに悪影響があるため、改行位置を統一するようお願いします。

レビューいただきありがとうございます。修正しました。改行については今後も英文版とdiff常にとるように留意します。よろしくおねがいします。

koba04

@uehaj レイアウトと、単語の言い換えが中心ですが、コメントしたので確認お願いします 🙏

Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

smikitky · 2019-03-06T04:44:42Z

ここまで確認しました。4箇所不必要な改行（ないし <br> 直書き）が残っている以外はOKそうです

163行目: <br><br>
222行目付近
423行目付近
438行目付近（最終行の直上）

smikitky · 2019-03-06T06:57:09Z

よさそうです、ありがとうございました！

koba04 · 2019-03-06T11:04:05Z

@uehaj mergeしました！ 🚀 ありがとうございます！！ 🎉🎉🎉

uehaj · 2019-03-07T00:28:31Z

ありがとうございました! もう他には翻訳未着手はないですね。(ほぼ)おめでとうございます!

uehaj added 4 commits February 6, 2019 20:45

add initial japanese version from crowdin
0488412

basic tranlation completed
de697b7

remove english part
1465425

textlint checked
401ec03

uehaj force-pushed the optimizing-performance branch from 257bc66 to 401ec03Compare February 15, 2019 00:28

fix conflict
fb79320

uehaj force-pushed the optimizing-performance branch from d90fea0 to fb79320Compare February 16, 2019 09:01

smikitky changed the title ~~WIP: Optimizing performance~~Optimizing performanceFeb 16, 2019

smikitky self-requested a review February 25, 2019 09:21

smikitky added the 🚫 in intial review 初期レビューの真っ最中 label Feb 25, 2019

smikitky requested changes Feb 25, 2019
View reviewed changes

smikitky removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 25, 2019

tesseralis mentioned this pull request Feb 25, 2019
Japanese Translation Progress #4
Closed
90 tasks

smikitky mentioned this pull request Feb 27, 2019
Decide on translation of some terms #3
Closed

smikitkyand others added 8 commits March 2, 2019 19:09

Update content/docs/optimizing-performance.md
ddf7100
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

Update content/docs/optimizing-performance.md
59bbfaa
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

Update content/docs/optimizing-performance.md
5ab1f9d
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

Update content/docs/optimizing-performance.md
05ff20c
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

Update content/docs/optimizing-performance.md
2876b74
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

Update content/docs/optimizing-performance.md
ef9ad18
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

Update content/docs/optimizing-performance.md
2640175
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

Update content/docs/optimizing-performance.md
22a0825
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

smikitkyand others added 4 commits March 2, 2019 19:16

Update content/docs/optimizing-performance.md
4e95d05
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

Update content/docs/optimizing-performance.md
1790fa9
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

Update content/docs/optimizing-performance.md
244a46f
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

fix review commened points
1a61aa1

overall replace rendaring->renda- and paragraph/newlines
a94605c

uehaj changed the title ~~Optimizing performance~~WIP: Optimizing performanceMar 2, 2019

smikitkyand others added 5 commits March 2, 2019 20:21

Update content/docs/optimizing-performance.md
c3d9555
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

Update content/docs/optimizing-performance.md
d58eee4
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

Update content/docs/optimizing-performance.md
98520f7
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

all review comment are resolved
673eee1

Merge branch 'optimizing-performance' ofhttps://github.com/uehaj/ja.…
363f8d4
…reactjs.org into optimizing-performance

uehaj changed the title ~~WIP: Optimizing performance~~Optimizing performanceMar 2, 2019

uehaj added 2 commits March 3, 2019 18:41

Merge branch 'master' ofhttps://github.com/reactjs/ja.reactjs.org
a54ac41

Merge branch 'master' into optimizing-performance
4918ecc

koba04 requested changes Mar 4, 2019
View reviewed changes

koba04and others added 7 commits March 6, 2019 12:50

Update content/docs/optimizing-performance.md
80442d4
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

Update content/docs/optimizing-performance.md
d0f09a8
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

Update content/docs/optimizing-performance.md
25030da
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

Update content/docs/optimizing-performance.md
169de09
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

Update content/docs/optimizing-performance.md
5b208cc
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

Update content/docs/optimizing-performance.md
498d558
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

Update content/docs/optimizing-performance.md
6e97c02
Co-Authored-By: uehaj <59012+uehaj@users.noreply.github.com>

uehaj added 2 commits March 6, 2019 15:11

resolve commentend point at 2nd review
a3d3ae2

Merge branch 'master' into optimizing-performance
d1570d1

smikitky requested changes Mar 6, 2019
View reviewed changes

Comment threadcontent/docs/optimizing-performance.md Outdated

resolve rest of commentend point at 2nd review
e5e854d

smikitky approved these changes Mar 6, 2019
View reviewed changes

Merge branch 'master' into optimizing-performance
1faf91f

koba04 approved these changes Mar 6, 2019
View reviewed changes

koba04 merged commit bc0a2a0 into reactjs:masterMar 6, 2019

Uh oh!

Conversation

uehaj commented Feb 14, 2019

Uh oh!

smikitky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlifyBot commented Mar 2, 2019

Uh oh!

netlifyBot commented Mar 2, 2019

Uh oh!

netlifyBot commented Mar 2, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

uehaj commented Mar 2, 2019

Uh oh!

koba04 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smikitky commented Mar 6, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

smikitky commented Mar 6, 2019

Uh oh!

koba04 commented Mar 6, 2019

Uh oh!

uehaj commented Mar 7, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlifyBot commented Mar 2, 2019•
edited
Loading

smikitky commented Mar 6, 2019•
edited
Loading

uehaj commented Mar 7, 2019•
edited
Loading