Skip to content

Translate how-to-contribute - #123

Merged
potato4d merged 14 commits into
reactjs:masterfrom
oimo23:develop
Feb 27, 2019
Merged

Translate how-to-contribute#123
potato4d merged 14 commits into
reactjs:masterfrom
oimo23:develop

Conversation

@oimo23

@oimo23oimo23 commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@oimo23

oimo23 commented Feb 15, 2019

Copy link
Copy Markdown
ContributorAuthor

related issue: #4
Translation: How to Contribute

すみません、誤まって description が空欄になっていました。
レビューをよろしくお願いいたします🙇

potato4d
potato4d suggested changes Feb 16, 2019
View reviewed changes

@potato4dpotato4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oimo23
レビューの前段階として、 Lint エラーの修正をお願いいたします。
yarn でパッケージをインストール後、 yarn lint:text で確認できます！

@oimo23

oimo23 commented Feb 19, 2019

Copy link
Copy Markdown
ContributorAuthor

@potato4d
失礼しました、Lintエラー修正をしましたので再度よろしくお願いします！

potato4d
potato4d suggested changes Feb 23, 2019
View reviewed changes

@potato4dpotato4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ざっと見ました！
ほとんど機械的な変更となりますが、対応いただけると助かります！

Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
@potato4d@oimo23
Update content/docs/how-to-contribute.md
bab9524
Co-Authored-By: oimo23 <oimo2338@gmail.com>
@netlify

netlifyBot commented Feb 25, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ja-reactjs ready!

Built with commit 8e1862e

https://deploy-preview-123--ja-reactjs.netlify.com

potato4dand others added 3 commits February 25, 2019 13:19
@potato4d@oimo23
Update content/docs/how-to-contribute.md
27d7c7f
Co-Authored-By: oimo23 <oimo2338@gmail.com>
@potato4d@oimo23
Update content/docs/how-to-contribute.md
7341196
Co-Authored-By: oimo23 <oimo2338@gmail.com>
@oimo23
Fix lint error
dbb6973
@oimo23

oimo23 commented Feb 25, 2019

Copy link
Copy Markdown
ContributorAuthor

@potato4d
レビューありがとうございます。
suggest を取り込んで修正させて頂きました！

smikitky
smikitky requested changes Feb 25, 2019
View reviewed changes

@smikitkysmikitky left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遅くなりましたがレビューしましたので確認をお願いします。
あと「出来る」が複数残っているので「できる」に置換していただいてよいでしょうか。

Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
@potato4d

potato4d commented Feb 25, 2019

Copy link
Copy Markdown
Contributor

Mixed content でエラーが出ているけれど、これは原文もそうなので仕方なさそう？

@tesseralistesseralis mentioned this pull request Feb 25, 2019
Closed
90 tasks
@oimo23

oimo23 commented Feb 25, 2019

Copy link
Copy Markdown
ContributorAuthor

@smikitky
丁寧なレビューありがとうございます。
修正と、suggest の取り込みをさせて頂きました。

@potato4d
この規模のOSS貢献にはまだ不慣れで、色々と不手際があって申し訳ないです！
現在は直ったと思います、よろしくお願いします。

smikitky
smikitky requested changes Feb 26, 2019
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません、幾つか対応されていなかったものがあります。前のレビューは忘れてよいので改めてこちらを確認いただけますでしょうか。

「あなた」が文中にかなり多用されていましたが、他の翻訳との整合性もあるので必要でない部分については省くサジェスチョンをさせていただきました。（逆に1か所「あなた」に対応する語がないと意味が通らなくなる部分があるので追加しました。）

Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
@smikitky@oimo23
Apply suggestions from code review
b5a16a3
Co-Authored-By: oimo23 <oimo2338@gmail.com>
@smikitky

smikitky commented Feb 26, 2019

Copy link
Copy Markdown
Member

ありがとうございました！

@oimo23

oimo23 commented Feb 26, 2019

Copy link
Copy Markdown
ContributorAuthor

@smikitky
改めて今回の suggest を取り込ませて頂きました。
こちらこそありがとうございました！

potato4d
potato4d approved these changes Feb 27, 2019
View reviewed changes

@potato4dpotato4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oimo23
いえ、翻訳いただいてとても助かりました！ありがとうございます！

LGTM

@potato4d
potato4d merged commit 64ddd16 into reactjs:masterFeb 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smikitkysmikitkysmikitky approved these changes
+1 more reviewer
@potato4dpotato4dpotato4d approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oimo23@potato4d@smikitky