Translate API Reference of React.Component by lightnet328 · Pull Request #127 · reactjs/ja.react.dev

lightnet328 · 2019-02-16T18:50:09Z

This PR is a part of #4.
Translate: React.Component – React

netlify · 2019-02-20T00:00:20Z

Deploy preview for ja-reactjs ready!

Built with commit 5c79337

https://deploy-preview-127--ja-reactjs.netlify.com

koba04

@lightnet328
翻訳お疲れ様です！
長いページなので、コメント多くなってしまいましたがご確認お願いします！ 🙇
細かいものばかりです。

koba04 · 2019-02-20T16:00:21Z

+`forceUpdate()` を呼び出すと、`shouldComponentUpdate()` をスキップして、コンポーネントに対して `render()` が呼び出されます。これにより、それぞれの子の `shouldComponentUpdate()` メソッドを含む、子コンポーネントの通常のライフサイクルメソッドがトリガーされます。マークアップが変更された場合にのみ React は DOM を更新します。

-Normally you should try to avoid all uses of `forceUpdate()` and only read from `this.props` and `this.state` in `render()`.
+通常は `forceUpdate()` の使用をすべて避け、`render()` の `this.props` と `this.state` からのみ読み取るようにしてください。


言い回しを調整しました [IMO]
Suggested change
通常は`forceUpdate()`の使用をすべて避け、`render()` の `this.props` と `this.state` からのみ読み取るようにしてください。
通常は全ての`forceUpdate()`の使用を避け、`render()` の `this.props` と `this.state` からのみ読み取るようにしてください。

こちら、ご提案いただいた内容のほうが良いと思うので取り込ませていただきました。
また、「通常は forceUpdate() を使用せずに、」ではどうでしょうか？意訳しすぎでしょうか。

@lightnet328
また、「通常は forceUpdate() を使用せずに、」ではどうでしょうか？意訳しすぎでしょうか。
いいと思います！

Co-Authored-By: lightnet328 <lightnet328@gmail.com>

lightnet328 · 2019-02-20T17:06:45Z

@koba04 レビューしていただき、ありがとうございます！
訳の誤りの修正と言い回しに関して、提案していただいたものの方が良いと思ったので取り込ませていただきました(1つ1つ修正の内容・理由について示していただき、ありがとうございます🙏)。
非常に細かい点について、1つコメントしたのでご確認いただきたいです。
#127 (comment)
よろしくお願いいたします。

koba04

@lightnet328 表示がおかしくなっている部分があったのでコメントしましたのでそこだけ確認お願いします 🙏
1つは自分がsuggestionした部分でした。失礼しました 🙇

Co-Authored-By: lightnet328 <lightnet328@gmail.com>

lightnet328 · 2019-02-22T14:02:37Z

Markdownが崩れている部分について修正しました🙇

koba04 · 2019-02-22T16:36:52Z

@lightnet328 対応ありがとうございました！

potato4d

良さそうです！
ありがとうございました！

lightnet328 added 4 commits February 17, 2019 03:47

doc: Translate API Reference of React.Component
31a7d29

Fix about the correspondence of line feeds with original sentences
a425fdc

Remove sentences
208541c

Fix lint errors
0bffbd1

lightnet328 changed the title ~~doc: Translate API Reference of React.Component~~Translate API Reference of React.ComponentFeb 16, 2019

smikitky self-requested a review February 17, 2019 05:35

Merge branch 'master' into translate/api-reference-react-component
090f998

tesseralis mentioned this pull request Feb 18, 2019
Japanese Translation Progress #4
Closed
90 tasks

tesseralis requested a review from koba04 February 19, 2019 23:55

Merge branch 'master' into translate/api-reference-react-component
7d0aba2

koba04 added the 🚫 in intial review 初期レビューの真っ最中 label Feb 20, 2019

koba04 requested changes Feb 20, 2019
View reviewed changes

koba04 removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 20, 2019

koba04and others added 13 commits February 21, 2019 01:32

Update content/docs/reference-react-component.md
46b4ec3
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
85b7297
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
b7806c8
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
807dd6b
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
4d28afd
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
2810c91
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
abae6ad
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
e4e1215
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
6f867b7
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
dcb5a51
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
5c428b6
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
ec0a1f1
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
7442bb1
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

koba04 requested changes Feb 21, 2019
View reviewed changes

Comment threadcontent/docs/reference-react-component.md Outdated
Comment threadcontent/docs/reference-react-component.md Outdated
Comment threadcontent/docs/reference-react-component.md Outdated

lightnet328 force-pushed the translate/api-reference-react-component branch from 2c70307 to 80d8236Compare February 22, 2019 13:51

koba04and others added 13 commits February 22, 2019 23:00

Update content/docs/reference-react-component.md
8e11618
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
1c2f460
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
e7be391
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
e81113b
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
05ac6cd
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
de3d345
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
3b70172
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
91cb2ba
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
095e7e7
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
cf425a7
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
3de5d1e
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Update content/docs/reference-react-component.md
ddb9ef0
Co-Authored-By: lightnet328 <lightnet328@gmail.com>

Fix a blockquote
bb7b035

lightnet328 force-pushed the translate/api-reference-react-component branch from 7763181 to bb7b035Compare February 22, 2019 14:00

Merge branch 'master' into translate/api-reference-react-component
5c79337

koba04 approved these changes Feb 22, 2019
View reviewed changes

tesseralis requested a review from potato4d February 23, 2019 02:43

potato4d approved these changes Feb 23, 2019
View reviewed changes

potato4d merged commit 671a685 into reactjs:masterFeb 23, 2019

	通常は`forceUpdate()`の使用をすべて避け、`render()` の `this.props` と `this.state` からのみ読み取るようにしてください。
	通常は全ての`forceUpdate()`の使用を避け、`render()` の `this.props` と `this.state` からのみ読み取るようにしてください。

Uh oh!

Conversation

lightnet328 commented Feb 16, 2019

Uh oh!

netlifyBot commented Feb 20, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

koba04 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

koba04Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

lightnet328Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

koba04Feb 21, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lightnet328 commented Feb 20, 2019

Uh oh!

koba04 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lightnet328 commented Feb 22, 2019

Uh oh!

koba04 commented Feb 22, 2019

Uh oh!

potato4d left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

netlifyBot commented Feb 20, 2019•
edited
Loading

koba04 left a comment •
edited
Loading