Skip to content

Translate design-principles - #133

Merged
koba04 merged 8 commits into
reactjs:masterfrom
hand-dot:tr/design-principles
Mar 2, 2019
Merged

Translate design-principles#133
koba04 merged 8 commits into
reactjs:masterfrom
hand-dot:tr/design-principles

Conversation

@hand-dot

@hand-dothand-dot commented Feb 20, 2019

Copy link
Copy Markdown
Contributor

This PR is part of Issue #4.
Translation: Design Principles

レビューをお願いいたします。

@netlify

netlifyBot commented Feb 20, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ja-reactjs ready!

Built with commit eeb050f

https://deploy-preview-133--ja-reactjs.netlify.com

@potato4d
potato4d requested review from potato4d and removed request for potato4dFebruary 20, 2019 04:51
@potato4d

potato4d commented Feb 20, 2019

Copy link
Copy Markdown
Contributor

今晩見れそうなら assign 入れてみます 🙇

@hand-dot

hand-dot commented Feb 20, 2019

Copy link
Copy Markdown
ContributorAuthor

今晩見れそうなら assign 入れてみます 🙇

ありがとうございます！よろしくお願い致します。

@smikitkysmikitky added the 🚫 in intial review 初期レビューの真っ最中 label Feb 25, 2019
smikitky
smikitky requested changes Feb 25, 2019
View reviewed changes

@smikitkysmikitky left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遅くなりましたがレビューしました。数が多いですが、特にドキュメントの後半で直訳すぎる部分が散見されましたので、読みやすいように変えたところが多くなっています。よろしくお願いします。

"Files Changed" のタブ側に移動すれば複数のサジェスチョンを1コミットで適用できますので使ってみてください。

Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
@smikitkysmikitky removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 25, 2019
@tesseralistesseralis mentioned this pull request Feb 25, 2019
Closed
90 tasks
@smikitky@hand-dot
Apply suggestions from code review
c1e18c4
Co-Authored-By: hand-dot <kyouhei.fukuda0729@gmail.com>
@hand-dot

hand-dot commented Feb 26, 2019

Copy link
Copy Markdown
ContributorAuthor

@smikitky
レビューしていただきありがとうございます。
指摘を確認し、サジェスチョンを適用しました。
よろしくお願い致します。

@smikitky

smikitky commented Feb 26, 2019

Copy link
Copy Markdown
Member

ありがとうございました。他の方のレビューをお待ちください

koba04
koba04 requested changes Mar 1, 2019
View reviewed changes

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hand-dot
翻訳お疲れ様です！
一点だけ用語の確認お願いします 🙏

Comment threadcontent/docs/design-principles.md Outdated
@koba04@hand-dot
Update content/docs/design-principles.md
9d70d4a
Co-Authored-By: hand-dot <kyouhei.fukuda0729@gmail.com>
@hand-dot

hand-dot commented Mar 2, 2019

Copy link
Copy Markdown
ContributorAuthor

@koba04
ありがとうございます！
指摘内容を取り込みました。

よろしくお願いします。

koba04
koba04 approved these changes Mar 2, 2019
View reviewed changes

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hand-dot ありがとうございます！ 👍

@koba04
koba04 merged commit 8327dae into reactjs:masterMar 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koba04koba04koba04 approved these changes
@smikitkysmikitkysmikitky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hand-dot@potato4d@smikitky@koba04