Skip to content

doc: Translate /docs navigations - #149

Merged
koba04 merged 2 commits into
masterfrom
translate/navs
Feb 26, 2019
Merged

doc: Translate /docs navigations#149
koba04 merged 2 commits into
masterfrom
translate/navs

Conversation

@potato4d

Copy link
Copy Markdown
Contributor

This PR is a part of #4

コアページの翻訳が一通り完了したため、現状で翻訳済みの範囲について nav.yml へと反映しました。

@netlify

netlifyBot commented Feb 25, 2019

Copy link
Copy Markdown

Deploy preview for ja-reactjs ready!

Built with commit 20d229e

https://deploy-preview-149--ja-reactjs.netlify.com

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こうやって並べてみると整合性が悪いので変えた方がいい部分があるように思えますが(特にリファレンス周り)、とりあえずマージして、あとで修正した方がよさそうですねー

@tesseralistesseralis mentioned this pull request Feb 25, 2019
90 tasks
@potato4d

Copy link
Copy Markdown
ContributorAuthor

そうですね、ここで編集してしまうと対応するドキュメントも編集する必要が出てきてしまうので、一旦やりきってからがよさそうです。

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@koba04
koba04 merged commit ca3c264 into masterFeb 26, 2019
@potato4d
potato4d deleted the translate/navs branch February 26, 2019 02:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@potato4d@koba04@smikitky