Skip to content

translate lifting-state-up doc - #15

Merged
smikitky merged 4 commits into
reactjs:masterfrom
sasurau4:translate/lifting-state-up
Feb 3, 2019
Merged

translate lifting-state-up doc#15
smikitky merged 4 commits into
reactjs:masterfrom
sasurau4:translate/lifting-state-up

Conversation

@sasurau4

@sasurau4sasurau4 commented Feb 1, 2019

Copy link
Copy Markdown
Contributor

This PR is part of #4
Please review and comment 🙏

@smikitky
smikitky self-requested a review February 1, 2019 16:08
@smikitky

smikitky commented Feb 1, 2019

Copy link
Copy Markdown
Member

ぱっと見はとてもいい感じだと思います。細かいレビューはちょっとお待ちください。

smikitky
smikitky requested changes Feb 2, 2019
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大量ですみません。大多数はスペースとかの些細なスタイルの問題です。ご確認をお願いします。

Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
@sasurau4

sasurau4 commented Feb 2, 2019

Copy link
Copy Markdown
ContributorAuthor

@smikitky
むっちゃスタイルガイドに沿ってなかったので一掃しました
レビューお願いします 🙏

@tesseralistesseralis mentioned this pull request Feb 2, 2019
Closed
90 tasks
smikitky
smikitky requested changes Feb 3, 2019
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらの2つだけ改めて対応をお願い致します。

Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
@smikitky@sasurau4
Apply suggestions from code review
4950619
fix pointed out
Co-Authored-By: sasurau4 <sasurau4@gmail.com>
@sasurau4

sasurau4 commented Feb 3, 2019

Copy link
Copy Markdown
ContributorAuthor

@smikitky 対応しました 👍

@smikitky
smikitky merged commit ab1da7c into reactjs:masterFeb 3, 2019
@smikitky

smikitky commented Feb 3, 2019

Copy link
Copy Markdown
Member

ありがとうございました！

@sasurau4
sasurau4 deleted the translate/lifting-state-up branch February 15, 2019 06:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smikitkysmikitkysmikitky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sasurau4@smikitky