Translate thinking-in-react by Nkzn · Pull Request #16 · reactjs/ja.react.dev

Nkzn · 2019-02-01T16:01:51Z

Translation for Thinking in React.

#4

smikitky · 2019-02-03T01:20:21Z

UIを1要素 などでも半角スペース挿入をお願いします

…sion.

koba04

@Nkzn
いくつかフォーマットとtypoを修正したので確認お願いします! 🙇

smikitky

こちらで確認をお願いします。全体に「あなた」が他の記事より多用されていたため、減らして簡潔な表現に寄せたりしています。

Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

Nkzn · 2019-02-05T02:52:33Z

suggested change同士でコンフリクトした場合の対応ってどうしたらいいんでしょう・・・（いくつかoutdatedになってしまった）

smikitky · 2019-02-05T03:53:02Z

妥当だと思われる文章で普通に手でコミットしていただけると。

Nkzn · 2019-02-05T04:43:33Z

@smikitky @koba04 レビューありがとうございました！　修正しました！

smikitky · 2019-02-05T05:26:15Z

私はこれで大丈夫そうです

koba04

@Nkzn 一点、「。」が抜けている部分があったのでそこだけ対応お願いします 🙇
そのほかはOKだと思います! 🎉

Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

Nkzn · 2019-02-05T09:24:17Z

@koba04 すいませんでした・・・！！！！！！！

koba04 · 2019-02-05T09:36:16Z

@Nkzn ありがとうございます！マージしました 🎉🎉🎉

Nkzn · 2019-02-05T09:36:40Z

ありがとうございました🙌

Nkzn added 6 commits February 3, 2019 15:49

docs(thinking-in-react): write lead sentence
0062337

docs(thinking-in-react): Thinking in React - Step 1
89d45ee

docs(thinking-in-react): add spaces
25db10b

docs(thinking-in-react): Add "Single Responsibility Principle" expres…
5e138c8
…sion.

docs(thinking-in-react): Add spaces
60026ec

docs(thinking-in-react): Thinking in React - Step 2
86f8072

Nkzn force-pushed the thinking-in-react-ja branch from 5837532 to 86f8072Compare February 3, 2019 06:51

Nkzn added 4 commits February 3, 2019 20:10

docs(thinking-in-react): フィルター => フィルタ
e874a5a

docs(thinking-in-react): Thinking in React - Step 3
e21131d

docs(thinking-in-react): Step 3の邦題を変更しました
f287a6f

docs(thinking-in-react): Thinking in React - Step 4
930c87d

Nkzn force-pushed the thinking-in-react-ja branch from bb8d618 to 930c87dCompare February 3, 2019 15:01

docs(thinking-in-react): Thinking in React - Step 5 & 'And That's It'
6cc5bbc

Nkzn changed the title ~~WIP: Translate thinking-in-react~~Translate thinking-in-reactFeb 3, 2019

koba04 self-requested a review February 4, 2019 01:15

koba04 requested changes Feb 4, 2019
View reviewed changes

Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated

smikitky requested changes Feb 4, 2019
View reviewed changes

koba04and others added 12 commits February 5, 2019 11:36

docs(thinking-in-react): Accept suggested change
7a8e063
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
ab2d566
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
fa807fd
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
97fd7cf
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
ac1efb6
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
01eac00
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
94311c2
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
2c7af19
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
61d4ccd
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
373763f
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
67bdce2
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
4d6fa38
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

smikitkyand others added 13 commits February 5, 2019 11:43

docs(thinking-in-react): Accept suggested change
8aabf35
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
db0e67a
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
b02b0a0
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
eb5b068
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
8a75670
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
5e35fd3
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
eaf3083
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
f7be522
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
c315e2b
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
1f9824f
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
da0e7b7
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
c3edc26
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

docs(thinking-in-react): Accept suggested change
5a822e5
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

Yukiya Nakagawa added 3 commits February 5, 2019 13:37

docs(thinking-in-react): Accept suggested change
670bddf

docs(thinking-in-react): Add issue number
7695b95

docs(thinking-in-react): タイトルを「Reactの流儀」にしてみました
eb2efd2

smikitky approved these changes Feb 5, 2019
View reviewed changes

koba04 requested changes Feb 5, 2019
View reviewed changes

Comment threadcontent/docs/thinking-in-react.md Outdated

docs(thinking-in-react): Accept suggested change
dac01c6
Co-Authored-By: Nkzn <y.nakagawa@water-cell.jp>

koba04 approved these changes Feb 5, 2019
View reviewed changes

koba04 merged commit 1ef8830 into reactjs:masterFeb 5, 2019

tesseralis mentioned this pull request Feb 5, 2019
Japanese Translation Progress #4
Closed
90 tasks

Uh oh!

Conversation

Nkzn commented Feb 1, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smikitky commented Feb 3, 2019

Uh oh!

koba04 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smikitky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nkzn commented Feb 5, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smikitky commented Feb 5, 2019

Uh oh!

Nkzn commented Feb 5, 2019

Uh oh!

smikitky commented Feb 5, 2019

Uh oh!

koba04 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Nkzn commented Feb 5, 2019

Uh oh!

koba04 commented Feb 5, 2019

Uh oh!

Nkzn commented Feb 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Nkzn commented Feb 1, 2019•
edited
Loading

Nkzn commented Feb 5, 2019•
edited
Loading