Skip to content

Translate hooks-intro - #18

Merged
smikitky merged 7 commits into
masterfrom
tr/hooks-intro
Feb 2, 2019
Merged

Translate hooks-intro#18
smikitky merged 7 commits into
masterfrom
tr/hooks-intro

Conversation

@smikitky

Copy link
Copy Markdown
Member

This is the first PR for the translation for Hooks.

Note: Currently React 16.8 is scheduled to be out on February 4th, which mean this article may be out of date VERY soon. So we may not have to be too strict on the quality.

@tesseralistesseralis mentioned this pull request Feb 1, 2019
90 tasks

@potato4dpotato4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smikitky
翻訳お疲れ様です。いくつかコメントをしたのでご確認いただけると幸いです!
また、これから Hooks が広く使われる可能性はありますので、 #3 に Hooks についての取扱もあわせて入れることを検討しましょうか。

Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md
Co-Authored-By: smikitky <smiki-tky@umin.ac.jp>

@potato4dpotato4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良いと思います 👍

@koba04
koba04 self-requested a review February 2, 2019 10:39

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かい点ですが、いくつかコメントしておきました。

Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
Comment threadcontent/docs/hooks-intro.md Outdated
koba04and others added 2 commits February 2, 2019 21:05
Co-Authored-By: smikitky <smiki-tky@umin.ac.jp>
@smikitky

Copy link
Copy Markdown
MemberAuthor

@potato4d@koba04 ありがとうございました!

@smikitky
smikitky merged commit 83bc3bb into masterFeb 2, 2019
@koba04
koba04 deleted the tr/hooks-intro branch February 2, 2019 14:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@smikitky@koba04@potato4d