Skip to content

Translate testing - #241

Merged
koba04 merged 13 commits into
reactjs:masterfrom
taneba:translate/testing
Sep 4, 2019
Merged

Translate testing#241
koba04 merged 13 commits into
reactjs:masterfrom
taneba:translate/testing

Conversation

@taneba

@tanebataneba commented Aug 30, 2019

Copy link
Copy Markdown
Contributor

This PR is part of #4
1/3 of testing docs

@netlify

netlifyBot commented Aug 30, 2019

Copy link
Copy Markdown

Deploy preview for ja-reactjs ready!

Built with commit d82508c

https://deploy-preview-241--ja-reactjs.netlify.com

@netlify

netlifyBot commented Aug 30, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ja-reactjs ready!

Built with commit 1e547d1

https://deploy-preview-241--ja-reactjs.netlify.com

potato4d
potato4d reviewed Sep 1, 2019
View reviewed changes

@potato4dpotato4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いくつかコメントしました〜。

Comment threadcontent/docs/testing.md Outdated
Comment threadcontent/docs/testing.md Outdated
Comment threadcontent/docs/testing.md
potato4d
potato4d approved these changes Sep 2, 2019
View reviewed changes

@potato4dpotato4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ありがとうございました！

koba04
koba04 reviewed Sep 3, 2019
View reviewed changes

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taneba
翻訳ありがとうございます！！
細かい言い回しの修正ばかりですがコメントしたので確認お願いします 🙇

Comment threadcontent/docs/testing.md Outdated
Comment threadcontent/docs/testing.md Outdated
Comment threadcontent/docs/testing.md Outdated
Comment threadcontent/docs/testing.md Outdated
Comment threadcontent/docs/testing.md Outdated
Comment threadcontent/docs/testing.md Outdated
Comment threadcontent/docs/testing.md Outdated
Comment threadcontent/docs/testing.md Outdated
Comment threadcontent/docs/testing.md Outdated
Comment threadcontent/docs/testing.md Outdated
tanebaand others added 8 commits September 4, 2019 11:42
@taneba@koba04
Update content/docs/testing.md
36a344e
Co-Authored-By: Toru Kobayashi <koba0004@gmail.com>
@taneba@koba04
Update content/docs/testing.md
b6a5007
Co-Authored-By: Toru Kobayashi <koba0004@gmail.com>
@taneba@koba04
Update content/docs/testing.md
b581f26
Co-Authored-By: Toru Kobayashi <koba0004@gmail.com>
@taneba@koba04
Update content/docs/testing.md
1fef1b0
Co-Authored-By: Toru Kobayashi <koba0004@gmail.com>
@taneba@koba04
Update content/docs/testing.md
0ae1541
Co-Authored-By: Toru Kobayashi <koba0004@gmail.com>
@taneba@koba04
Update content/docs/testing.md
eca5968
Co-Authored-By: Toru Kobayashi <koba0004@gmail.com>
@taneba@koba04
Update content/docs/testing.md
a4e63df
Co-Authored-By: Toru Kobayashi <koba0004@gmail.com>
@taneba@koba04
Update content/docs/testing.md
0b42aed
Co-Authored-By: Toru Kobayashi <koba0004@gmail.com>
@taneba

taneba commented Sep 4, 2019

Copy link
Copy Markdown
ContributorAuthor

@koba04
レビューありがとうございました！
２点コメント返しましたのでご確認お願いします 🙇

tanebaand others added 2 commits September 4, 2019 13:54
@taneba@koba04
Update content/docs/testing.md
299278d
Co-Authored-By: Toru Kobayashi <koba0004@gmail.com>
@taneba@koba04
Update content/docs/testing.md
05bd182
Co-Authored-By: Toru Kobayashi <koba0004@gmail.com>
koba04
koba04 reviewed Sep 4, 2019
View reviewed changes

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taneba
すみません、suggestionsの内容が古いようでした。
@taneba さんの翻訳に近い形に戻したものが本来提案したかったものなので改めて確認お願いします。
お手数お掛けしてすみません 🙇

こちらでApproveにしたいと思います。

Comment threadcontent/docs/testing.md Outdated
@taneba@koba04
Update content/docs/testing.md
1e547d1
Co-Authored-By: Toru Kobayashi <koba0004@gmail.com>
koba04
koba04 approved these changes Sep 4, 2019
View reviewed changes

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 対応ありがとうございました！！

@koba04
koba04 merged commit 6c9b55c into reactjs:masterSep 4, 2019
@tesseralistesseralis mentioned this pull request Sep 4, 2019
Closed
90 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koba04koba04koba04 approved these changes
@smikitkysmikitkyAwaiting requested review from smikitky
+1 more reviewer
@potato4dpotato4dpotato4d approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@taneba@koba04@potato4d