Skip to content

Translate testing-recipes - #261

Merged
smikitky merged 4 commits into
masterfrom
tr/testing-recipes
Oct 30, 2019
Merged

Translate testing-recipes#261
smikitky merged 4 commits into
masterfrom
tr/testing-recipes

Conversation

@smikitky

Copy link
Copy Markdown
Member

一応理解して訳したつもりではありますが、実は React のテストは実際にやったことがない領域なので、経験のある方の確認をいただければ助かります。

nav.yaml への更新も含んでいます。

@smikitky
smikitkyforce-pushed the tr/testing-recipes branch 2 times, most recently from e77780b to a7f4bb9CompareOctober 24, 2019 10:40
@netlify

netlifyBot commented Oct 24, 2019

Copy link
Copy Markdown

Deploy preview for ja-reactjs ready!

Built with commit d1afac9

https://deploy-preview-261--ja-reactjs.netlify.com

@smikitky
smikitky marked this pull request as ready for review October 24, 2019 10:57
@smikitkysmikitky changed the title Trnslate testing-recipesTranslate testing-recipesOct 24, 2019
@reactjsreactjs deleted a comment from netlifyBotOct 24, 2019
@reactjsreactjs deleted a comment from netlifyBotOct 24, 2019

@potato4dpotato4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

私も React のテストは airbnb/enzyme を利用した少し古いものまでしか詳しい部分は把握していませんが、ざっと見た感じ問題なさそうです。
翻訳ありがとうございます!

いくつか nits と memo を書きました。

Comment threadcontent/docs/testing-recipes.md Outdated
Comment threadcontent/docs/testing-recipes.md
Comment threadcontent/docs/testing-recipes.md Outdated

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 特に気になる点はありませんでした!

@potato4dpotato4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです。ありがとうございます!

@tesseralistesseralis mentioned this pull request Oct 28, 2019
90 tasks
@smikitky
smikitky merged commit bff2faa into masterOct 30, 2019
@smikitky
smikitky deleted the tr/testing-recipes branch October 30, 2019 05:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@smikitky@koba04@potato4d