Skip to content

Translate hooks-overview (Hooks at a Glance) - #48

Merged
smikitky merged 5 commits into
masterfrom
tr/hooks-overview
Feb 13, 2019
Merged

Translate hooks-overview (Hooks at a Glance)#48
smikitky merged 5 commits into
masterfrom
tr/hooks-overview

Conversation

@smikitky

Copy link
Copy Markdown
Member

This is the second chapter of Hooks documentation.

「早わかり」という訳がちょっとアレかもしれないのですがそこはご意見をお待ちしています

@tesseralistesseralis mentioned this pull request Feb 3, 2019
90 tasks
@koba04
koba04 self-requested a review February 4, 2019 01:16

@sasurau4sasurau4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いくつかコメントしました 🙏

Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
@koba04
koba04 removed their request for review February 4, 2019 09:40
@koba04
koba04 self-requested a review February 4, 2019 14:59

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かい点ですが、いくつかコメントしましたので確認お願いします。

Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
@smikitky

Copy link
Copy Markdown
MemberAuthor

@koba04 全部対応しました、ありがとうございました!

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応ありがとうございました!

@smikitky

Copy link
Copy Markdown
MemberAuthor

#91 でフックに関わる差分がマージされます。翻訳を修正するまでマージはお待ちください。

@smikitky

Copy link
Copy Markdown
MemberAuthor

#91 の差分のマージを終えました

@smikitky

Copy link
Copy Markdown
MemberAuthor

見出しID修正が取り込まれていなかったので rebase & force-push しました。

@potato4d どうでしょう?

@potato4d

Copy link
Copy Markdown
Contributor

明日の朝見ます 🙇

@potato4dpotato4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです!

@smikitky
smikitky merged commit e5fe12e into masterFeb 13, 2019
@smikitky
smikitky deleted the tr/hooks-overview branch February 13, 2019 08:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@smikitky@potato4d@koba04@sasurau4