Skip to content

Translate render-props - #49

Merged
koba04 merged 15 commits into
reactjs:masterfrom
ossan-engineer:render-props
Feb 6, 2019
Merged

Translate render-props#49
koba04 merged 15 commits into
reactjs:masterfrom
ossan-engineer:render-props

Conversation

@ossan-engineer

@ossan-engineerossan-engineer commented Feb 3, 2019

Copy link
Copy Markdown
Contributor

This PR is part of Issue #4.

@tesseralistesseralis mentioned this pull request Feb 3, 2019
Closed
90 tasks
@ossan-engineerossan-engineer changed the title [WIP] Translate render-propsTranslate render-propsFeb 3, 2019
@koba04
koba04 self-requested a review February 4, 2019 01:16
@smikitky
smikitky self-requested a review February 4, 2019 09:04
@koba04
koba04 removed their request for review February 4, 2019 09:40
@sasurau4

sasurau4 commented Feb 4, 2019

Copy link
Copy Markdown
Contributor

今からレビューします 🌠

sasurau4
sasurau4 suggested changes Feb 4, 2019
View reviewed changes

@sasurau4sasurau4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます 👍
大量に指摘しましたが、自信がない部分も多々あるのでコメントをいただけると 🙏
対応よろしくお願いします。

Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
sasurau4and others added 3 commits February 5, 2019 15:54
@sasurau4@ossan-engineer
Apply suggestions from code review
f2dd510
Co-Authored-By: ossan-engineer <bodega1123@gmail.com>
@sasurau4@ossan-engineer
Apply suggestions from code review
654c468
Co-Authored-By: ossan-engineer <bodega1123@gmail.com>
Kiichi Tachibana
Apply textlint
6be0d6f
smikitky
smikitky requested changes Feb 5, 2019
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

幾つか改善点を見つけましたので対応をお願いいたします。

Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
smikitky
smikitky reviewed Feb 5, 2019
View reviewed changes
Comment threadcontent/docs/render-props.md Outdated
@ossan-engineer
Apply suggestions from code review
02fdce9
Co-Authored-By: ossan-engineer <bodega1123@gmail.com>
@smikitky

smikitky commented Feb 6, 2019

Copy link
Copy Markdown
Member

最終文以外は確認しました。

@ossan-engineer

ossan-engineer commented Feb 6, 2019

Copy link
Copy Markdown
ContributorAuthor

@smikitky ありがとうございます！

@koba04
koba04 self-requested a review February 6, 2019 04:21
@smikitky@ossan-engineer
Update content/docs/render-props.md
53dd984
Co-Authored-By: ossan-engineer <bodega1123@gmail.com>
koba04
koba04 requested changes Feb 6, 2019
View reviewed changes

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要な改行と、わかりやすさを重視して「関数型 props」の言い方を単純に「関数の props」に変えてみたので確認お願いします。

Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md Outdated
Comment threadcontent/docs/render-props.md
smikitky
smikitky approved these changes Feb 6, 2019
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一応1個だけスペースの抜けを見つけたので修正お願いします。（レビューは approve にしておきます）

Comment threadcontent/docs/render-props.md Outdated
ossan-engineerand others added 2 commits February 6, 2019 21:12
@ossan-engineer
Apply suggestions from code review
dee41b5
Co-Authored-By: ossan-engineer <bodega1123@gmail.com>
Kiichi Tachibana
Remove unnecessary empty lines
26d692e
@ossan-engineer

ossan-engineer commented Feb 6, 2019

Copy link
Copy Markdown
ContributorAuthor

@koba04@smikitky@sasurau4 諸々修正しましたので、お手すきでご確認お願いいたします。

@koba04
koba04 merged commit 9680e25 into reactjs:masterFeb 6, 2019
@koba04

koba04 commented Feb 6, 2019

Copy link
Copy Markdown
Member

@ossan-engineer mergeしました！！ 🎉 ありがとうございます！ 👏👏👏

@ossan-engineer

ossan-engineer commented Feb 6, 2019

Copy link
Copy Markdown
ContributorAuthor

@koba04 ありがとうございます！

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koba04koba04koba04 approved these changes
@smikitkysmikitkysmikitky approved these changes
+1 more reviewer
@sasurau4sasurau4sasurau4 requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ossan-engineer@sasurau4@smikitky@koba04