Skip to content

Translate hooks-state (Using the State Hook) - #51

Merged
smikitky merged 4 commits into
masterfrom
tr/hooks-state
Feb 7, 2019
Merged

Translate hooks-state (Using the State Hook)#51
smikitky merged 4 commits into
masterfrom
tr/hooks-state

Conversation

@smikitky

@smikitkysmikitky commented Feb 3, 2019

Copy link
Copy Markdown
Member

First translation of hooks-state.md

@tesseralistesseralis mentioned this pull request Feb 3, 2019
Closed
90 tasks
@koba04
koba04 requested review from koba04 and removed request for koba04February 4, 2019 01:17
@koba04koba04 added the 🚫 in intial review 初期レビューの真っ最中 label Feb 4, 2019
koba04
koba04 requested changes Feb 4, 2019
View reviewed changes

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューしましたので確認お願いします 🙇

Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
@koba04koba04 removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 4, 2019
@smikitky

smikitky commented Feb 5, 2019

Copy link
Copy Markdown
MemberAuthor

@koba04 丁寧なレビューありがとうございました！

@potato4d

potato4d commented Feb 5, 2019

Copy link
Copy Markdown
Contributor

次自分もこれ見ますねー。

potato4d
potato4d reviewed Feb 5, 2019
View reviewed changes

@potato4dpotato4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューしました 👀
個人的にページ内のリンクの必須だと思っている(メンテナ以外が翻訳した場合に、後から気づくことが容易ではないため)ですが、意見をもらえるとありがたいです。

Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md Outdated
Comment threadcontent/docs/hooks-state.md
koba04
koba04 requested changes Feb 5, 2019
View reviewed changes

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点翻訳されていない文章があったのでそこだけお願いします！

Comment threadcontent/docs/hooks-state.md Outdated
@smikitky

smikitky commented Feb 5, 2019

Copy link
Copy Markdown
MemberAuthor

@koba04 修正しました、「まとめ」のところがハイライトされていたので気づきませんでした…

@potato4d ページ内アンカーについては別 issue の通りです。他は対応しました。

@koba04

koba04 commented Feb 5, 2019

Copy link
Copy Markdown
Member

対応ありがとうございました！

@smikitky

smikitky commented Feb 7, 2019

Copy link
Copy Markdown
MemberAuthor

#91 でフックに関わる差分がマージされます。翻訳を修正するまでマージはお待ちください。

potato4d
potato4d approved these changes Feb 7, 2019
View reviewed changes

@potato4dpotato4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうです。Approve は出しておくので、タイミングをあわせてマージしてください 🙏

@smikitky
smikitky merged commit 94fccbb into masterFeb 7, 2019
@potato4d
potato4d deleted the tr/hooks-state branch February 20, 2019 03:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koba04koba04koba04 approved these changes
+1 more reviewer
@potato4dpotato4dpotato4d approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smikitky@potato4d@koba04