Skip to content

Translate react-without-es6 - #53

Merged
smikitky merged 23 commits into
reactjs:masterfrom
ginpei:react-without-es6
Feb 4, 2019
Merged

Translate react-without-es6#53
smikitky merged 23 commits into
reactjs:masterfrom
ginpei:react-without-es6

Conversation

@ginpei

@ginpeiginpei commented Feb 3, 2019

Copy link
Copy Markdown
Contributor

Advanced Guides > React Without ES6の翻訳です。

ginpei
ginpei commented Feb 3, 2019
View reviewed changes

@ginpeiginpei left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assign @smikitky as a reviewer

とのことでしたが、変更できないので no reviews のままです。すみません、レビューお願いします！

Comment threadcontent/docs/react-without-es6.md
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md
Comment threadcontent/docs/react-without-es6.md Outdated
@smikitky
smikitky self-requested a review February 3, 2019 08:21
smikitky
smikitky requested changes Feb 3, 2019
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューしましたのでこちらの確認をよろしくお願いします！

Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
@tesseralistesseralis mentioned this pull request Feb 3, 2019
Closed
90 tasks
smikitkyand others added 17 commits February 3, 2019 10:53
@smikitky@ginpei
Update content/docs/react-without-es6.md
fc86c5a
Co-Authored-By: ginpei <ginpei@gmail.com>
@smikitky@ginpei
Update content/docs/react-without-es6.md
d34be5c
Co-Authored-By: ginpei <ginpei@gmail.com>
@smikitky@ginpei
Update content/docs/react-without-es6.md
488607b
Co-Authored-By: ginpei <ginpei@gmail.com>
@smikitky@ginpei
Update content/docs/react-without-es6.md
3220bff
Co-Authored-By: ginpei <ginpei@gmail.com>
@smikitky@ginpei
Update content/docs/react-without-es6.md
82928c8
Co-Authored-By: ginpei <ginpei@gmail.com>
@smikitky@ginpei
Update content/docs/react-without-es6.md
4f284a4
Co-Authored-By: ginpei <ginpei@gmail.com>
@smikitky@ginpei
Update content/docs/react-without-es6.md
c829bfd
Co-Authored-By: ginpei <ginpei@gmail.com>
@smikitky@ginpei
Update content/docs/react-without-es6.md
0aa3d9d
Co-Authored-By: ginpei <ginpei@gmail.com>
@smikitky@ginpei
Update content/docs/react-without-es6.md
2e3cc58
Co-Authored-By: ginpei <ginpei@gmail.com>
@smikitky@ginpei
Update content/docs/react-without-es6.md
0acf07f
Co-Authored-By: ginpei <ginpei@gmail.com>
@smikitky@ginpei
Update content/docs/react-without-es6.md
91d4dd2
Co-Authored-By: ginpei <ginpei@gmail.com>
@smikitky@ginpei
Update content/docs/react-without-es6.md
5ec71c8
Co-Authored-By: ginpei <ginpei@gmail.com>
@smikitky@ginpei
Update content/docs/react-without-es6.md
1b05824
Co-Authored-By: ginpei <ginpei@gmail.com>
@smikitky@ginpei
Update content/docs/react-without-es6.md
2c7b689
Co-Authored-By: ginpei <ginpei@gmail.com>
@smikitky@ginpei
Update content/docs/react-without-es6.md
8f04e4f
Co-Authored-By: ginpei <ginpei@gmail.com>
@smikitky@ginpei
Update content/docs/react-without-es6.md
d874e5b
Co-Authored-By: ginpei <ginpei@gmail.com>
@ginpei
not waiting but wanting
01948be
@ginpei

ginpei commented Feb 3, 2019

Copy link
Copy Markdown
ContributorAuthor

納得のいく suggestions だったので一通り取り込みました。

@koba04
koba04 self-requested a review February 4, 2019 01:17
@smikitky

smikitky commented Feb 4, 2019

Copy link
Copy Markdown
Member

私の方ではOKです。@koba04 さん待ち。

koba04
koba04 requested changes Feb 4, 2019
View reviewed changes

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ginpei 不要なーがあったのでその点だけコメントしました！

Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
@koba04@ginpei
Update content/docs/react-without-es6.md
b8a909a
Co-Authored-By: ginpei <ginpei@gmail.com>
koba04and others added 2 commits February 3, 2019 21:35
@ginpei

ginpei commented Feb 4, 2019

Copy link
Copy Markdown
ContributorAuthor

そのルールを失念しておりました。自分でも見直して修正しました。 🙏

@ginpei

ginpei commented Feb 4, 2019

Copy link
Copy Markdown
ContributorAuthor

「レガシー」は一般的なカタカナ日本語と判断して残しました。

@smikitky
smikitky merged commit 7c6584b into reactjs:masterFeb 4, 2019
@smikitky

smikitky commented Feb 4, 2019

Copy link
Copy Markdown
Member

ありがとうございました！

@ginpei
ginpei deleted the react-without-es6 branch February 14, 2019 03:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koba04koba04koba04 approved these changes
@smikitkysmikitkysmikitky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ginpei@smikitky@koba04