Skip to content

Translate hooks-effect (Using the Effect Hook) - #54

Merged
potato4d merged 6 commits into
masterfrom
tr/hooks-effect
Feb 7, 2019
Merged

Translate hooks-effect (Using the Effect Hook)#54
potato4d merged 6 commits into
masterfrom
tr/hooks-effect

Conversation

@smikitky

@smikitkysmikitky commented Feb 3, 2019

Copy link
Copy Markdown
Member

4th (out of 8) article of the Hooks series

@tesseralistesseralis mentioned this pull request Feb 3, 2019
Closed
90 tasks
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
@smikitky

smikitky commented Feb 3, 2019

Copy link
Copy Markdown
MemberAuthor

@takanorip ありがとうございます、コメントした数カ所にお返事いただけますでしょうか

@koba04
koba04 requested review from koba04 and removed request for koba04February 4, 2019 01:17
koba04
koba04 requested changes Feb 6, 2019
View reviewed changes

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smikitky 細かい点をいくつかSuggestしたので確認お願いします 🙇

Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
@smikitky

smikitky commented Feb 6, 2019

Copy link
Copy Markdown
MemberAuthor

@koba04 対応しました！

koba04
koba04 approved these changes Feb 6, 2019
View reviewed changes

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smikitky 対応ありがとうございました！

takanoripand others added 5 commits February 7, 2019 12:41
@takanorip@smikitky
Apply suggestions from code review
ece1764
Co-Authored-By: smikitky <smiki-tky@umin.ac.jp>
@takanorip@smikitky
Apply suggestions from code review
a072b66
Co-Authored-By: smikitky <smiki-tky@umin.ac.jp>
@smikitky
Fix textlint error
1d910ef
@smikitky
Remove garbage
398f58e
@koba04@smikitky
Apply suggestions from code review
0a68f39
Co-Authored-By: smikitky <smiki-tky@umin.ac.jp>
@smikitky

smikitky commented Feb 7, 2019

Copy link
Copy Markdown
MemberAuthor

（force-push してもちゃんと conversations は維持されるんですね…さすが GitHub）

@smikitky

smikitky commented Feb 7, 2019

Copy link
Copy Markdown
MemberAuthor

@potato4d 一通り対応終わりましたので確認＆マージをお願いできれば

@potato4d

potato4d commented Feb 7, 2019

Copy link
Copy Markdown
Contributor

@smikitky
既存のレビュー中身が終わるまで Approve してもなというところだったので、内容は既に見ておりますー！
議論が収束したみたいなので、 Approve とマージしてしまいますね。

@potato4d
potato4d merged commit 0e8d93b into masterFeb 7, 2019
@smikitky

smikitky commented Feb 7, 2019

Copy link
Copy Markdown
MemberAuthor

@potato4d@takanorip ありがとうございました！

@potato4d
potato4d deleted the tr/hooks-effect branch February 20, 2019 03:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koba04koba04koba04 approved these changes
+2 more reviewers
@takanoriptakanoriptakanorip left review comments
@potato4dpotato4dpotato4d approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smikitky@potato4d@koba04@takanorip