Skip to content

Translate shallow-renderer - #56

Merged
koba04 merged 11 commits into
reactjs:masterfrom
sakit0:ShallowRenderer-ja
Feb 7, 2019
Merged

Translate shallow-renderer#56
koba04 merged 11 commits into
reactjs:masterfrom
sakit0:ShallowRenderer-ja

Conversation

@sakit0

@sakit0sakit0 commented Feb 3, 2019

Copy link
Copy Markdown
Contributor

Translate shallow-renderer

issue : #4

Please review.

takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/addons-shallow-renderer.md Outdated
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/addons-shallow-renderer.md Outdated
takanorip
takanorip reviewed Feb 3, 2019
View reviewed changes
Comment threadcontent/docs/addons-shallow-renderer.md Outdated
takanoripand others added 4 commits February 4, 2019 00:35
@takanorip@sakit0
Update content/docs/addons-shallow-renderer.md
ceee55e
Co-Authored-By: sakito21 <sakito21@gmail.com>
@takanorip@sakit0
Update content/docs/addons-shallow-renderer.md
e16d7df
Co-Authored-By: sakito21 <sakito21@gmail.com>
@takanorip@sakit0
Update content/docs/addons-shallow-renderer.md
11aca87
Co-Authored-By: sakito21 <sakito21@gmail.com>
@sakit0
英字、数字の前後に空白を入れる修正
acd2b09
@smikitky

smikitky commented Feb 4, 2019

Copy link
Copy Markdown
Member

レビューは後になりますが、とりあえず render は「レンダー」ですが renderer は「レンダラ」でお願いします。タイトルの Shallow Renderer についてもアルファベットのままで残していいと思していいと思います。

@koba04
koba04 requested review from koba04 and removed request for koba04February 4, 2019 01:18
@sakit0

sakit0 commented Feb 4, 2019

Copy link
Copy Markdown
ContributorAuthor

@smikitky
個人的に訳し過ぎていたと思う部分を修正しました🙏
8a27fd0

@tesseralistesseralis mentioned this pull request Feb 5, 2019
Closed
90 tasks
smikitky
smikitky requested changes Feb 5, 2019
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 少しだけ日本語に戻しました
  • あとはスペースなど微修正です

Comment threadcontent/docs/addons-shallow-renderer.md Outdated
Comment threadcontent/docs/addons-shallow-renderer.md Outdated
Comment threadcontent/docs/addons-shallow-renderer.md Outdated
@koba04koba04 mentioned this pull request Feb 6, 2019
Merged
smikitkyand others added 3 commits February 7, 2019 23:52
@smikitky@sakit0
Update content/docs/addons-shallow-renderer.md
16861f4
Co-Authored-By: sakito21 <sakito21@gmail.com>
@smikitky@sakit0
Update content/docs/addons-shallow-renderer.md
2a22aa2
Co-Authored-By: sakito21 <sakito21@gmail.com>
@smikitky@sakit0
Update content/docs/addons-shallow-renderer.md
b290914
Co-Authored-By: sakito21 <sakito21@gmail.com>
koba04
koba04 requested changes Feb 7, 2019
View reviewed changes

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sakito21 一点だけ表記の確認お願いします 🙏

Comment threadcontent/docs/addons-shallow-renderer.md Outdated
@koba04@sakit0
Update content/docs/addons-shallow-renderer.md
f7f3846
Co-Authored-By: sakito21 <sakito21@gmail.com>
@koba04
koba04 merged commit 81db23d into reactjs:masterFeb 7, 2019
@koba04

koba04 commented Feb 7, 2019

Copy link
Copy Markdown
Member

@sakito21 ありがとうございます！マージしました 🚀🚀🚀

@sakit0
sakit0 deleted the ShallowRenderer-ja branch February 8, 2019 03:27
@sakit0

sakit0 commented Feb 8, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@koba04@smikitky@takanorip ありがとうございました！

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koba04koba04koba04 approved these changes
@smikitkysmikitkysmikitky approved these changes
+1 more reviewer
@takanoriptakanoriptakanorip left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sakit0@smikitky@koba04@takanorip