Skip to content

Translate useDebugValue hook reference - #573

Merged
koba04 merged 3 commits into
reactjs:mainfrom
seckie:api_reference_use_debug_value
May 21, 2023
Merged

Translate useDebugValue hook reference#573
koba04 merged 3 commits into
reactjs:mainfrom
seckie:api_reference_use_debug_value

Conversation

@seckie

@seckieseckie commented May 12, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

初めてのコントリビューションになります。
Reference > useDebugValue を試しに翻訳してみました。
ChatGPT (GPT-4) での翻訳をベースにして、既存の翻訳や legacy ドキュメントの翻訳の方針に沿って修正をしています。

お役に立てそうでしょうか。ご確認よろしくお願いいたします。

@seckie
seckie marked this pull request as ready for review May 12, 2023 15:22
@smikitkysmikitky mentioned this pull request May 13, 2023
Open
@smikitkysmikitky added the 🚫 in intial review 初期レビューの真っ最中 label May 13, 2023
smikitky
smikitky requested changes May 13, 2023
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。

些細な訳語統一やフォーマットの指摘が殆どですが対応をお願いします。

React Dev Tools の inspect は訳すなら「検証」よりは「調査」が良いと思います。そういえば Chrome の開発者ツールもずっと「検証」を使っている気がしますが、個人的にはあれはいつも意味不明だなと思っています…。とはいえ今回は原文併記でカタカナにしておくのが無難な気がしました。

Comment threadsrc/content/reference/react/useDebugValue.md Outdated
Comment threadsrc/content/reference/react/useDebugValue.md Outdated
Comment threadsrc/content/reference/react/useDebugValue.md Outdated
Comment threadsrc/content/reference/react/useDebugValue.md Outdated
Comment threadsrc/content/reference/react/useDebugValue.md Outdated
Comment threadsrc/content/reference/react/useDebugValue.md Outdated
Comment threadsrc/content/reference/react/useDebugValue.md Outdated
Comment threadsrc/content/reference/react/useDebugValue.md Outdated
@smikitkysmikitky removed the 🚫 in intial review 初期レビューの真っ最中 label May 13, 2023
@seckie@smikitky
Apply suggestions from code review
79a23aa
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
smikitky
smikitky approved these changes May 13, 2023
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございました！
メンテナが 2 人 approve してからマージするルールになっていますのでもう少しお待ちください。

@github-actions

github-actionsBot commented May 13, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

koba04
koba04 approved these changes May 21, 2023
View reviewed changes

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 初コントリビューションありがとうございます！！！

@koba04
koba04 merged commit 801dc31 into reactjs:mainMay 21, 2023
@seckieseckie mentioned this pull request May 21, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koba04koba04koba04 approved these changes
@smikitkysmikitkysmikitky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seckie@koba04@smikitky