Skip to content

Translate jsx-in-depth - #62

Merged
potato4d merged 3 commits into
reactjs:masterfrom
sato11:translate/jsx-in-depth
Feb 14, 2019
Merged

Translate jsx-in-depth#62
potato4d merged 3 commits into
reactjs:masterfrom
sato11:translate/jsx-in-depth

Conversation

@sato11

@sato11sato11 commented Feb 4, 2019

Copy link
Copy Markdown
Contributor

This PR is part of #4.
Added translation to JSX In Depth section.

Quite a few sentences are originally taken from crowdin. I have filled missing parts and arranged or rewritten some of them to make it stylistically more consistent.

よろしくお願いします :) @smikitky

@tesseralistesseralis mentioned this pull request Feb 5, 2019
Closed
90 tasks
@smikitky
smikitky self-requested a review February 5, 2019 05:53
@smikitkysmikitky added the 🚫 in intial review 初期レビューの真っ最中 label Feb 7, 2019
smikitky
smikitky requested changes Feb 7, 2019
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほとんど大丈夫ですが少しだけ提案です。

Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
@smikitkysmikitky removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 7, 2019
potato4d
potato4d reviewed Feb 7, 2019
View reviewed changes

@potato4dpotato4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sato11
翻訳ありがとうございます 🙏

smikitky さんの指摘の変更点以外は特になさそうです。
一点、タイトルの部分で対案があったので書いておきました〜。

Comment threadcontent/docs/jsx-in-depth.md Outdated
@sato11

sato11 commented Feb 7, 2019

Copy link
Copy Markdown
ContributorAuthor

@smikitky@potato4d
レビューありがとうございました。
ご指摘に沿う形で変更を行いましたので、引き続きよろしくお願いします。

@sato11
sato11force-pushed the translate/jsx-in-depth branch from 7495cec to 14b6604CompareFebruary 13, 2019 12:17
@sato11

sato11 commented Feb 13, 2019

Copy link
Copy Markdown
ContributorAuthor

@smikitky@potato4d
こちらのコメント見逃してしまっておりすみませんでした。
適用しましたので再度ご確認いただけますでしょうか、よろしくお願いします 🙏
#4 (comment)

@smikitky

smikitky commented Feb 13, 2019

Copy link
Copy Markdown
Member

ありがとうございます！

potato4d
potato4d approved these changes Feb 14, 2019
View reviewed changes

@potato4dpotato4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです！

@potato4d
potato4d merged commit 2cb8402 into reactjs:masterFeb 14, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smikitkysmikitkysmikitky approved these changes
+1 more reviewer
@potato4dpotato4dpotato4d approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sato11@smikitky@potato4d