Skip to content

Translate "<Fragment>" - #626

Merged
koba04 merged 4 commits into
reactjs:mainfrom
jp-knj:Fragment
Aug 4, 2023
Merged

Translate "<Fragment>"#626
koba04 merged 4 commits into
reactjs:mainfrom
jp-knj:Fragment

Conversation

@jp-knj

@jp-knjjp-knj commented Jul 16, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actionsBot commented Jul 18, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@smikitkysmikitky mentioned this pull request Jul 18, 2023
Open
@jp-knjjp-knj changed the title Translate "Fragment"Translate "<Fragment>"Jul 18, 2023
jp-knj
jp-knj commented Jul 22, 2023
View reviewed changes
Comment threadsrc/content/reference/react/Fragment.md Outdated
Comment threadsrc/content/reference/react/Fragment.md
Comment threadsrc/content/reference/react/Fragment.md
Comment threadsrc/content/reference/react/Fragment.md
@jp-knj
jp-knj marked this pull request as ready for review July 22, 2023 16:07
smikitky
smikitky requested changes Jul 23, 2023
View reviewed changes

@smikitkysmikitky left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

読みやすさのために直訳すぎる部分を補った部分と、逆に一部直訳に近づけた部分があります。ご確認ください。

Comment threadsrc/content/reference/react/Fragment.md Outdated
Comment threadsrc/content/reference/react/Fragment.md Outdated
Comment threadsrc/content/reference/react/Fragment.md Outdated
Comment threadsrc/content/reference/react/Fragment.md Outdated
Comment threadsrc/content/reference/react/Fragment.md Outdated
Comment threadsrc/content/reference/react/Fragment.md Outdated
Comment threadsrc/content/reference/react/Fragment.md Outdated
Comment threadsrc/content/reference/react/Fragment.md Outdated
Comment threadsrc/content/reference/react/Fragment.md Outdated
Comment threadsrc/content/reference/react/Fragment.md Outdated
@smikitky

smikitky commented Jul 23, 2023

Copy link
Copy Markdown
Member

Files Changed のタブから "Add suggestion to batch" をつかってまとめてコミットをお願いします。

jp-knj

This comment was marked as off-topic.

Sign in to view

@jp-knj@smikitky
Apply suggestions from code review
9d99733
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
smikitky
smikitky approved these changes Jul 23, 2023
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございました！

@jp-knj

jp-knj commented Jul 24, 2023

Copy link
Copy Markdown
ContributorAuthor

こちらこそ、ありがとうございます😊

koba04
koba04 approved these changes Aug 4, 2023
View reviewed changes

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ありがとうございます！！

@koba04
koba04 merged commit 0d0aba6 into reactjs:mainAug 4, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koba04koba04koba04 approved these changes
@smikitkysmikitkysmikitky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jp-knj@smikitky@koba04