Skip to content

Translate createContext - #638

Merged
koba04 merged 7 commits into
reactjs:mainfrom
natsuokawai:translate-createContext
Aug 24, 2023
Merged

Translate createContext#638
koba04 merged 7 commits into
reactjs:mainfrom
natsuokawai:translate-createContext

Conversation

@natsuokawai

@natsuokawainatsuokawai commented Jul 19, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@natsuokawai
natsuokawaiforce-pushed the translate-createContext branch from fd608af to 79fea47CompareJuly 19, 2023 16:49
@natsuokawai
natsuokawaiforce-pushed the translate-createContext branch from 79fea47 to 4a1d04aCompareJuly 19, 2023 16:52
smikitky
smikitky approved these changes Jul 20, 2023
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほとんどは訳語統一やフォーマット関連です。ご確認をお願いします。

Comment threadsrc/content/reference/react/createContext.md Outdated
Comment threadsrc/content/reference/react/createContext.md Outdated
Comment threadsrc/content/reference/react/createContext.md Outdated
Comment threadsrc/content/reference/react/createContext.md Outdated
Comment threadsrc/content/reference/react/createContext.md Outdated
Comment threadsrc/content/reference/react/createContext.md Outdated
Comment threadsrc/content/reference/react/createContext.md Outdated
Comment threadsrc/content/reference/react/createContext.md Outdated
Comment threadsrc/content/reference/react/createContext.md Outdated
Comment threadsrc/content/reference/react/createContext.md Outdated
smikitky
smikitky requested changes Jul 20, 2023
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

間違って approve してしまったので request changes し直します

@smikitkysmikitky mentioned this pull request Jul 20, 2023
Open
@natsuokawai

natsuokawai commented Jul 20, 2023

Copy link
Copy Markdown
ContributorAuthor

レビューありがとうございます。スタイルの指摘を多くさせてしまいすみません。

smikitky
smikitky requested changes Jul 20, 2023
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 箇所修正漏れがあるようですので対応をお願いします。

Comment threadsrc/content/reference/react/createContext.md Outdated
@github-actions

github-actionsBot commented Jul 20, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@smikitky

smikitky commented Jul 20, 2023

Copy link
Copy Markdown
Member

すみません、リンクが複数箇所外れているのに気付いたので修正させていただきました。

koba04
koba04 approved these changes Aug 24, 2023
View reviewed changes

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ありがとうございます！！

@koba04
koba04 merged commit ea6fb5c into reactjs:mainAug 24, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koba04koba04koba04 approved these changes
@smikitkysmikitkysmikitky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@natsuokawai@smikitky@koba04