Skip to content

Translate "<select>" component - #644

Merged
koba04 merged 7 commits into
reactjs:mainfrom
ainoshment:translate-select-component
Aug 28, 2023
Merged

Translate "<select>" component#644
koba04 merged 7 commits into
reactjs:mainfrom
ainoshment:translate-select-component

Conversation

@ainoshment

@ainoshmentainoshment commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

react-dom: Components の <select> の翻訳です。

ainoshment
ainoshment commented Jul 27, 2023
View reviewed changes
Comment threadsrc/content/reference/react-dom/components/select.md Outdated
smikitky
smikitky requested changes Aug 2, 2023
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

幾つかの修正と、読みやすくするための suggestion を行いましたので確認をお願いします。

Comment threadsrc/content/reference/react-dom/components/select.md Outdated
`<select>` は[一般的な要素の props](/reference/react-dom/components/common#props) をすべてサポートしています。

You can [make a select box controlled](#controlling-a-select-box-with-a-state-variable) by passing a `value` prop:
`value` プロパティを渡すことで、[セレクトボックスを制御](#controlling-a-select-box-with-a-state-variable)できます。

@smikitkysmikitkyAug 2, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`value` プロパティを渡すことで、[セレクトボックスを制御](#controlling-a-select-box-with-a-state-variable)できます。
`value` プロパティを渡すことで、[セレクトボックスを制御されたコンポーネント (controlled component)](#controlling-a-select-box-with-a-state-variable) にできます。

訳語統一です

Comment threadsrc/content/reference/react-dom/components/select.md Outdated
Comment threadsrc/content/reference/react-dom/components/select.md Outdated
Comment threadsrc/content/reference/react-dom/components/select.md Outdated
Comment threadsrc/content/reference/react-dom/components/select.md Outdated
Comment threadsrc/content/reference/react-dom/components/select.md Outdated
Comment threadsrc/content/reference/react-dom/components/select.md Outdated
Comment threadsrc/content/reference/react-dom/components/select.md Outdated
Comment threadsrc/content/reference/react-dom/components/select.md Outdated
Comment threadsrc/content/reference/react-dom/components/select.md Outdated
@ainoshment

ainoshment commented Aug 6, 2023

Copy link
Copy Markdown
ContributorAuthor

@smikitky （修正箇所が多くて😓）お手数をおかけしました...！修正を行いましたのでご確認よろしくお願いします！

@smikitky

smikitky commented Aug 8, 2023

Copy link
Copy Markdown
Member

ありがとうございました。1箇所だけスタイルの問題を追加で修正させていただきました(3a4613c)。

@github-actions

github-actionsBot commented Aug 8, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@smikitkysmikitky mentioned this pull request Aug 8, 2023
Open
koba04
koba04 requested changes Aug 27, 2023
View reviewed changes

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ainoshment
レビューありがとうございます！一点、Markdown フォーマットの修正だけ提案したので確認お願いします！

Comment threadsrc/content/reference/react-dom/components/select.md Outdated
@smikitky
smikitky requested a review from koba04August 27, 2023 19:05
koba04
koba04 approved these changes Aug 28, 2023
View reviewed changes

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@koba04
koba04 merged commit 0db8947 into reactjs:mainAug 28, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smikitkysmikitkysmikitky approved these changes
@koba04koba04koba04 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ainoshment@smikitky@koba04