Skip to content

Translate "findDOMNode" - #670

Merged
koba04 merged 4 commits into
reactjs:mainfrom
jp-knj:findDOMNode
Sep 18, 2023
Merged

Translate "findDOMNode"#670
koba04 merged 4 commits into
reactjs:mainfrom
jp-knj:findDOMNode

Conversation

@jp-knj

@jp-knjjp-knj commented Aug 27, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actionsBot commented Aug 27, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

jp-knj
jp-knj commented Aug 30, 2023
View reviewed changes
Comment threadsrc/content/reference/react-dom/findDOMNode.md
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
@jp-knj
jp-knj marked this pull request as ready for review September 2, 2023 14:58
@koba04koba04 mentioned this pull request Sep 7, 2023
Open
smikitky
smikitky requested changes Sep 13, 2023
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遅くなり申し訳ありません。確認・対応をお願いします。

Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
Comment threadsrc/content/reference/react-dom/findDOMNode.md Outdated
@jp-knj@smikitky
Apply suggestions from code review
3d5be97
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
@jp-knj

jp-knj commented Sep 14, 2023

Copy link
Copy Markdown
ContributorAuthor

"Files Changed" タブで "Add suggestion to batch" しました、確認お願いします

smikitky
smikitky approved these changes Sep 14, 2023
View reviewed changes

@smikitkysmikitky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！

koba04
koba04 approved these changes Sep 18, 2023
View reviewed changes

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ありがとうございます！！！

@koba04
koba04 merged commit 8e7d94a into reactjs:mainSep 18, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koba04koba04koba04 approved these changes
@smikitkysmikitkysmikitky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jp-knj@koba04@smikitky