Skip to content

Translate Codebase Overview - #123

Merged
gnujoow merged 13 commits into
reactjs:masterfrom
Kimguyeop:master
Oct 16, 2019
Merged

Translate Codebase Overview#123
gnujoow merged 13 commits into
reactjs:masterfrom
Kimguyeop:master

Conversation

@Kimguyeop

@KimguyeopKimguyeop commented May 22, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@netlify

netlifyBot commented May 22, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ko-reactjs-org ready!

Built with commit e86b844

https://deploy-preview-123--ko-reactjs-org.netlify.com

@taehwannotaehwanno changed the title TranslateTranslate Codebase OverviewMay 23, 2019
@tesseralistesseralis mentioned this pull request May 23, 2019
Open
hg-pyun
hg-pyun requested changes Jun 24, 2019
View reviewed changes
Comment threadcontent/docs/codebase-overview.md Outdated
Comment threadcontent/docs/codebase-overview.md Outdated
Comment threadcontent/docs/codebase-overview.md
Comment threadcontent/docs/codebase-overview.md Outdated
Comment threadcontent/docs/codebase-overview.md Outdated
@Kimguyeop

Kimguyeop commented Jul 16, 2019

Copy link
Copy Markdown
ContributorAuthor

수정해서 올렸습니다. 좋은 의견 감사합니다. !

hg-pyun
hg-pyun previously approved these changes Jul 16, 2019
View reviewed changes

@hg-pyunhg-pyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@taehwanno 시간되시면 +1 리뷰 부탁드립니다 :)

taehwanno
taehwanno suggested changes Jul 27, 2019
View reviewed changes

@taehwannotaehwanno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작은 수정사항 몇 가지 남겼습니다!

Comment threadcontent/docs/codebase-overview.md Outdated
Comment threadcontent/docs/codebase-overview.md Outdated
Comment threadcontent/docs/codebase-overview.md Outdated
Comment threadcontent/docs/codebase-overview.md Outdated
@Kimguyeop

Kimguyeop commented Sep 7, 2019

Copy link
Copy Markdown
ContributorAuthor

수정해서 올렸습니다. 좋은 의견 감사합니다.

gnujoow
gnujoow approved these changes Oct 16, 2019
View reviewed changes

@gnujoowgnujoow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 고생많으셨습니다.

@gnujoow
gnujoow merged commit 97cb8d8 into reactjs:masterOct 16, 2019
@gnujoowgnujoow mentioned this pull request Nov 19, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnujoowgnujoowgnujoow approved these changes
@hg-pyunhg-pyunhg-pyun left review comments
+1 more reviewer
@taehwannotaehwannotaehwanno approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kimguyeop@taehwanno@hg-pyun@gnujoow