Skip to content

Translate Implementation-notes.md - #129

Merged
taehwanno merged 8 commits into
reactjs:masterfrom
baekjuwon:OpenSourceTeam
Mar 7, 2020
Merged

Translate Implementation-notes.md#129
taehwanno merged 8 commits into
reactjs:masterfrom
baekjuwon:OpenSourceTeam

Conversation

@baekjuwon

@baekjuwonbaekjuwon commented May 26, 2019

Copy link
Copy Markdown
Contributor

@netlify

netlifyBot commented May 26, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ko-reactjs-org ready!

Built with commit f61e526

https://deploy-preview-129--ko-reactjs-org.netlify.com

@tesseralistesseralis mentioned this pull request May 26, 2019
Open
gnujoow
gnujoow requested changes Oct 16, 2019
View reviewed changes

@gnujoowgnujoow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체적으로 번역투의 문장이 많이 사용된것 같습니다.

Comment threadcontent/docs/implementation-notes.md Outdated
taehwanno
taehwanno suggested changes Nov 5, 2019
View reviewed changes

@taehwannotaehwanno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세부적인 기술 내용이 많아서 리뷰에 시간이 많이 드네요 😢 피드백 드려요 ㅎㅎ

Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
taehwanno
taehwanno suggested changes Nov 5, 2019
View reviewed changes

@taehwannotaehwanno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세부적인 기술 내용이 많아서 리뷰에 시간이 많이 드네요 😢 피드백 드려요 ㅎㅎ

taehwanno
taehwanno suggested changes Nov 5, 2019
View reviewed changes
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
@taehwanno

taehwanno commented Mar 7, 2020

Copy link
Copy Markdown
Contributor

제가 직접 수정해서 푸쉬할게요!

taehwanno
taehwanno approved these changes Mar 7, 2020
View reviewed changes

@taehwannotaehwanno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드의 영어 주석 번역이 필요한데 일단 반영하고 다른 PR에서 추가 번역하는 방향으로 가겠습니다. 고생하셨습니다!

@taehwanno
taehwanno merged commit b776c3c into reactjs:masterMar 7, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnujoowgnujoowgnujoow requested changes
+1 more reviewer
@taehwannotaehwannotaehwanno approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baekjuwon@taehwanno@gnujoow