Skip to content

Translate JSX In Depth - #177

Merged
hg-pyun merged 11 commits into
reactjs:masterfrom
hIkipooh:master
Mar 13, 2020
Merged

Translate JSX In Depth#177
hg-pyun merged 11 commits into
reactjs:masterfrom
hIkipooh:master

Conversation

@hIkipooh

@hIkipoohhIkipooh commented Oct 22, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

최초 피드백 사항이였던 다른 파일에 대한 불필요 커밋 제거 후 다시 pull request 요청합니다 ㅠ
주니어로 일 시작하고 정말 정신이 없어서 너무 오래 걸려서 죄송합니다 ㅠㅠ

Progress

@netlify

netlifyBot commented Oct 22, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ko-reactjs-org ready!

Built with commit ae0a6b0

https://deploy-preview-177--ko-reactjs-org.netlify.com

@taehwanno

taehwanno commented Oct 28, 2019

Copy link
Copy Markdown
Contributor

괜찮습니다 ㅎㅎ Progress에 마크다운 문법에 맞게 체크박스를 만들어놨어요. 각 단계별로 확인하시고 완료하셨다면 체크 부탁드릴게요.

@taehwannotaehwanno mentioned this pull request Oct 28, 2019
Closed
6 tasks
@taehwannotaehwanno changed the title Fixed mixed commit other than JSX in DepthTranslate JSX In DepthOct 30, 2019
gnujoow
gnujoow requested changes Nov 12, 2019
View reviewed changes
Comment threadcontent/docs/jsx-in-depth.md
Comment threadcontent/docs/jsx-in-depth.md
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
@hIkipooh

hIkipooh commented Nov 18, 2019

Copy link
Copy Markdown
ContributorAuthor

체크사항 및 피드백 사항 반영하여 다시 pull request 드립니다~!

taehwanno
taehwanno suggested changes Nov 30, 2019
View reviewed changes
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
taehwanno
taehwanno previously approved these changes Nov 30, 2019
View reviewed changes

@taehwannotaehwanno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몇 가지 직접 수정했습니다. 고생하셨습니다.

gnujoow
gnujoow requested changes Dec 5, 2019
View reviewed changes

@gnujoowgnujoow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

원문과 행이 맞지 않습니다. 포멧을 맞추기 위해 수정해주시면 감사하겠습니다.

Comment threadcontent/docs/jsx-in-depth.md
@hg-pyun
hg-pyun self-requested a review March 13, 2020 06:57
@hg-pyun

hg-pyun commented Mar 13, 2020

Copy link
Copy Markdown
Member

오래 기다리셨습니다. 더 이상 문제가 없다면 병합하도록 하겠습니다 :)

@hg-pyun
hg-pyun merged commit c27bee7 into reactjs:masterMar 13, 2020
@tesseralistesseralis mentioned this pull request Mar 13, 2020
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hg-pyunhg-pyunhg-pyun approved these changes
@gnujoowgnujoowAwaiting requested review from gnujoow
@taehwannotaehwannoAwaiting requested review from taehwanno

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hIkipooh@taehwanno@hg-pyun@gnujoow