Skip to content

Translate Composition vs Inheritance - #22

Merged
simsim0709 merged 5 commits into
reactjs:masterfrom
hewonjeong:composition-vs-inheritance
Feb 28, 2019
Merged

Translate Composition vs Inheritance#22
simsim0709 merged 5 commits into
reactjs:masterfrom
hewonjeong:composition-vs-inheritance

Conversation

@hewonjeong

@hewonjeonghewonjeong commented Feb 12, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Please let me know if you find any mistakes 🙇

References
https://reactjs-org-ko.netlify.com/docs/composition-vs-inheritance.html

hewonjeong
hewonjeong commented Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/composition-vs-inheritance.md
이 섹션에서는 React를 처음 접한 개발자들이 종종 상속으로 인해 부딪히는 몇 가지 문제들과 합성을 통해 이러한 문제를 해결하는 방법을 살펴볼 것입니다.

## Containment {#containment}
## 컴포넌트에서 다른 컴포넌트를 담기 {#containment}

@hewonjeonghewonjeongFeb 12, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

containment는 (좋지 않은 일의) 방지[억제], (다른 국가의 무력에 대한) 견제, 격납 등으로 해석하는데, 격납이라고만 해석하기엔 의미가 전달되는 것 같지 않아 내용을 조금 풀어서 컴포넌트에서 다른 컴포넌트를 담기라고 번역했습니다.

hewonjeong
hewonjeong commented Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/composition-vs-inheritance.md Outdated
BKJang
BKJang reviewed Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/composition-vs-inheritance.md Outdated
@ENvironmentSetENvironmentSet mentioned this pull request Feb 12, 2019
Closed
ENvironmentSet
ENvironmentSet suggested changes Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/composition-vs-inheritance.md Outdated
Comment threadcontent/docs/composition-vs-inheritance.md Outdated
@tesseralistesseralis mentioned this pull request Feb 12, 2019
Open
taggon
taggon reviewed Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/composition-vs-inheritance.md Outdated
Comment threadcontent/docs/composition-vs-inheritance.md Outdated
Comment threadcontent/docs/composition-vs-inheritance.md Outdated
Comment threadcontent/docs/composition-vs-inheritance.md Outdated
Comment threadcontent/docs/composition-vs-inheritance.md Outdated
Comment threadcontent/docs/composition-vs-inheritance.md Outdated
@hewonjeong

hewonjeong commented Feb 14, 2019

Copy link
Copy Markdown
ContributorAuthor

리뷰 반영하였습니다. 리뷰 남겨주신 분들 감사합니다🙇‍♂️

@simsim0709
simsim0709 self-requested a review February 28, 2019 04:43
simsim0709
simsim0709 approved these changes Feb 28, 2019
View reviewed changes

@simsim0709simsim0709 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! 👍

@netlify

netlifyBot commented Feb 28, 2019

Copy link
Copy Markdown

Deploy preview for ko-reactjs-org ready!

Built with commit 0769121

https://deploy-preview-22--ko-reactjs-org.netlify.com

@simsim0709
simsim0709 merged commit 3762413 into reactjs:masterFeb 28, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taggontaggontaggon left review comments
+4 more reviewers
@BKJangBKJangBKJang left review comments
@ENvironmentSetENvironmentSetENvironmentSet requested changes
@taehwannotaehwannotaehwanno approved these changes
@simsim0709simsim0709simsim0709 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hewonjeong@taggon@taehwanno@simsim0709@BKJang@ENvironmentSet