Skip to content

Translate ReactDOM - #28

Merged
hg-pyun merged 7 commits into
reactjs:masterfrom
noahluftyang:reference-react-dom
Mar 2, 2019
Merged

Translate ReactDOM#28
hg-pyun merged 7 commits into
reactjs:masterfrom
noahluftyang:reference-react-dom

Conversation

@noahluftyang

@noahluftyangnoahluftyang commented Feb 14, 2019

Copy link
Copy Markdown

Here is PR for reference-react-dom. I already checked suggested process below, but please review again and give me any feedback. 😇

@noahluftyangnoahluftyang mentioned this pull request Feb 14, 2019
Open
@taehwannotaehwanno mentioned this pull request Feb 15, 2019
Closed
hg-pyun
hg-pyun reviewed Feb 15, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-dom.md
taehwanno
taehwanno reviewed Feb 15, 2019
View reviewed changes
Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md Outdated
### 브라우저 지원 {#browser-support}

React supports all popular browsers, including Internet Explorer 9 and above, although [some polyfills are required](/docs/javascript-environment-requirements.html) for older browsers such as IE 9 and IE 10.
React는 Internet Explorer 9과 그 이후 버전을 포함한 모든 주요 브라우저를 지원합니다. 그러나 IE 9과 IE 10과 같은 구형 브라우저는 [polyfill이 필요합니다](/docs/javascript-environment-requirements.html).

@taehwannotaehwannoFeb 15, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React는 Internet Explorer 9와 상위 버전을 포함한 모든 주요 브라우저를 지원합니다. 그러나 IE 9와 IE 10과 같은 구형 브라우저는 폴리필(polyfill)이 필요합니다.

  • 그 이후 버전 -> 상위 버전 그리고 숫자 9에 대한 조사 사용(과 -> 와)에 대해 위처럼 수정 부탁드립니다.
  • polyfill에 대한 번역은 최초 등장시 폴리필(polyfill)로 번역하고 그 이후는 폴리필로 번역하도록 논의되고 있어요. translate glossary #2 (comment)

@noahluftyangnoahluftyangFeb 18, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9를 nine으로 읽는다고 생각해서 과로 번역했는데 구로 읽는게 더 자연스러운가요?

@taehwannotaehwannoFeb 18, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 저도 정확한 지침을 자세히 모르겠네요.

구글 검색을 통해 다른 회사의 사례를 살펴보면 위처럼 나오는데 는이 맞지 않을까 생각하고 있어요. 이에 대한 지침을 한번 찾아봐야겠네요.

@taehwannotaehwannoFeb 28, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taggon@simsim0709@gnujoow@hg-pyun@b9words
이 부분에 대한 의견 부탁드릴게요 :)

@simsim0709simsim0709Feb 28, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확실한 지침은 모르겠지만 9는을 더 많이 사용 하고 있는 것 같습니다.

Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md
Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md Outdated
Comment threadcontent/docs/reference-react-dom.md Outdated
@hg-pyun
hg-pyun merged commit 30c79a4 into reactjs:masterMar 2, 2019
@netlify

netlifyBot commented Mar 2, 2019

Copy link
Copy Markdown

Deploy preview for ko-reactjs-org ready!

Built with commit 291ba1b

https://deploy-preview-28--ko-reactjs-org.netlify.com

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hg-pyunhg-pyunhg-pyun approved these changes
+2 more reviewers
@simsim0709simsim0709simsim0709 left review comments
@taehwannotaehwannotaehwanno approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@noahluftyang@taehwanno@simsim0709@hg-pyun