Skip to content

Translate forms - #30

Merged
simsim0709 merged 12 commits into
reactjs:masterfrom
hyunalee419:translate-forms
Mar 6, 2019
Merged

Translate forms#30
simsim0709 merged 12 commits into
reactjs:masterfrom
hyunalee419:translate-forms

Conversation

@hyunalee419

@hyunalee419hyunalee419 commented Feb 16, 2019

Copy link
Copy Markdown
Contributor

React Form 페이지 번역했습니다.
피드백 부탁드립니다.

@tesseralistesseralis mentioned this pull request Feb 16, 2019
Open
BKJang
BKJang reviewed Feb 16, 2019
View reviewed changes
Comment threadcontent/docs/forms.md Outdated
taehwanno
taehwanno reviewed Feb 28, 2019
View reviewed changes

@taehwannotaehwanno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피드백이 늦었네요. 다음부터는 더 빨리 할 수 있도록 노력할게요 :)

Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
@netlify

netlifyBot commented Feb 28, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ko-reactjs-org ready!

Built with commit e0095a2

https://deploy-preview-30--ko-reactjs-org.netlify.com

@hyunalee419

hyunalee419 commented Mar 1, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@taehwanno 피드백 해주신대로 적용했습니다. 감사합니다 😄

taehwanno
taehwanno reviewed Mar 1, 2019
View reviewed changes

@taehwannotaehwanno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 피드백 감사합니다. 제가 하나를 빠뜨렸네요.

Comment threadcontent/docs/forms.md Outdated
taehwanno
taehwanno previously approved these changes Mar 4, 2019
View reviewed changes
taggon
taggon reviewed Mar 4, 2019
View reviewed changes

@taggontaggon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

줄 끝에 아마 의도하지 않은 것 같은 탭, 공백 문자가 있는 곳이 몇 군데 눈에 띕니다. 코멘트로는 두 군데만 말씀드렸지만 그 외에도 있으므로 확인해보시고, 의도한 게 아니라면 삭제부탁드립니다.

Comment threadcontent/docs/forms.md Outdated
Comment threadcontent/docs/forms.md Outdated
@hyunalee419

hyunalee419 commented Mar 4, 2019

Copy link
Copy Markdown
ContributorAuthor

@taggon 번역하다 실수로 공백이 들어간 것 같습니다. 😅
Files changed 에서 공백이라 생각되는 부분은 모두 처리했습니다. 확인 부탁드립니다~

@simsim0709
simsim0709 self-requested a review March 6, 2019 04:28
simsim0709
simsim0709 approved these changes Mar 6, 2019
View reviewed changes

@simsim0709simsim0709 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~ 👍

@simsim0709
simsim0709 merged commit c3dd530 into reactjs:masterMar 6, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taggontaggontaggon left review comments
+3 more reviewers
@BKJangBKJangBKJang left review comments
@taehwannotaehwannotaehwanno approved these changes
@simsim0709simsim0709simsim0709 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hyunalee419@taggon@taehwanno@simsim0709@BKJang