Skip to content

Translate Shallow Renderer - #40

Merged
simsim0709 merged 8 commits into
reactjs:masterfrom
hmu332233:master
Mar 12, 2019
Merged

Translate Shallow Renderer#40
simsim0709 merged 8 commits into
reactjs:masterfrom
hmu332233:master

Conversation

@hmu332233

@hmu332233hmu332233 commented Feb 20, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@tesseralistesseralis mentioned this pull request Feb 20, 2019
Open
gnujoow
gnujoow previously requested changes Feb 21, 2019
View reviewed changes
Comment threadcontent/docs/addons-shallow-renderer.md Outdated
@netlify

netlifyBot commented Feb 22, 2019

Copy link
Copy Markdown

Deploy preview for ko-reactjs-org ready!

Built with commit e50320c

https://deploy-preview-40--ko-reactjs-org.netlify.com

@netlify

netlifyBot commented Feb 22, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ko-reactjs-org ready!

Built with commit f42e2a8

https://deploy-preview-40--ko-reactjs-org.netlify.com

@taehwanno

taehwanno commented Feb 23, 2019

Copy link
Copy Markdown
Contributor

upstream과 sync되면서 master 브랜치의 모든 링크 주소가 https로 변경되어 직접 충돌 해결했습니다.

taehwanno
taehwanno reviewed Mar 10, 2019
View reviewed changes
Comment threadcontent/docs/addons-shallow-renderer.md Outdated
Comment threadcontent/docs/addons-shallow-renderer.md Outdated
Comment threadcontent/docs/addons-shallow-renderer.md Outdated
Comment threadcontent/docs/addons-shallow-renderer.md Outdated
Comment threadcontent/docs/addons-shallow-renderer.md Outdated
@hmu332233

hmu332233 commented Mar 11, 2019

Copy link
Copy Markdown
ContributorAuthor

@taehwanno
리뷰 반영했습니다.

다만 62번째 라인에서
테스트를 할 수 있다는 의미합니다. -> 테스트를 할 수 있음을 의미합니다.로 제안해주신 것을
테스트할 수 있음을 의미합니다.로 바꿔보았습니다.

@simsim0709
simsim0709 self-requested a review March 12, 2019 08:53
simsim0709
simsim0709 approved these changes Mar 12, 2019
View reviewed changes

@simsim0709simsim0709 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~ 👍

@simsim0709
simsim0709 dismissed gnujoow’s stale reviewMarch 12, 2019 08:56

리뷰 반영되어 제가 머지 했습니다.

@simsim0709
simsim0709 merged commit 4fac594 into reactjs:masterMar 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnujoowgnujoowgnujoow left review comments
+2 more reviewers
@taehwannotaehwannotaehwanno approved these changes
@simsim0709simsim0709simsim0709 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hmu332233@taehwanno@simsim0709@gnujoow