Skip to content

Translate Accessibility - #46

Merged
hg-pyun merged 7 commits into
reactjs:masterfrom
hiddenest:accessibility
May 23, 2019
Merged

Translate Accessibility#46
hg-pyun merged 7 commits into
reactjs:masterfrom
hiddenest:accessibility

Conversation

@hiddenest

@hiddenesthiddenest commented Feb 22, 2019•
edited by simsim0709
Loading

Copy link
Copy Markdown
Contributor

@hiddenesthiddenest mentioned this pull request Feb 22, 2019
Open
@netlify

netlifyBot commented Feb 22, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ko-reactjs-org ready!

Built with commit 3e4dca9

https://deploy-preview-46--ko-reactjs-org.netlify.com

@taehwanno

taehwanno commented Feb 23, 2019

Copy link
Copy Markdown
Contributor

upstream과 sync되면서 master 브랜치의 모든 링크 주소가 https로 변경 및 최신화되어 직접 충돌 해결했습니다.

hiddenest
hiddenest commented Feb 25, 2019
View reviewed changes
Comment threadcontent/docs/accessibility.md Outdated
taggon
taggon reviewed Feb 26, 2019
View reviewed changes
Comment threadcontent/docs/accessibility.md Outdated
Comment threadcontent/docs/accessibility.md Outdated
Comment threadcontent/docs/accessibility.md Outdated
Comment threadcontent/docs/accessibility.md Outdated
@hiddenest

hiddenest commented Feb 27, 2019

Copy link
Copy Markdown
ContributorAuthor

@taggon 말씀해주신 리뷰 사항 모두 반영하였습니다. 읽어주셔서 감사합니다 👍👍👍
혹시 또 문제가 있다면 바로 알려주세요 :)

taggon
taggon reviewed Mar 14, 2019
View reviewed changes
Comment threadcontent/docs/accessibility.md
Comment threadcontent/docs/accessibility.md Outdated
Comment threadcontent/docs/accessibility.md Outdated
Comment threadcontent/docs/accessibility.md Outdated
Comment threadcontent/docs/accessibility.md Outdated
Comment threadcontent/docs/accessibility.md Outdated
Comment threadcontent/docs/accessibility.md Outdated
Comment threadcontent/docs/accessibility.md Outdated
Comment threadcontent/docs/accessibility.md Outdated
Comment threadcontent/docs/accessibility.md Outdated
hg-pyun
hg-pyun reviewed Mar 27, 2019
View reviewed changes

@hg-pyunhg-pyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiddenest
수정되면 말씀해주세요!

taehwanno
taehwanno reviewed Mar 31, 2019
View reviewed changes
Comment threadcontent/docs/accessibility.md Outdated
Comment threadcontent/docs/accessibility.md Outdated
@simsim0709simsim0709 mentioned this pull request May 23, 2019
Closed
@simsim0709
simsim0709 self-requested a review May 23, 2019 08:07
simsim0709
simsim0709 approved these changes May 23, 2019
View reviewed changes

@simsim0709simsim0709 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨습니다~ 👍

@simsim0709
simsim0709 requested review from hg-pyun and taehwanno and removed request for hg-pyunMay 23, 2019 08:12
hg-pyun
hg-pyun approved these changes May 23, 2019
View reviewed changes

@hg-pyunhg-pyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hg-pyun
hg-pyun merged commit 96c1d3f into reactjs:masterMay 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taggontaggontaggon left review comments
@hg-pyunhg-pyunhg-pyun approved these changes
@taehwannotaehwannoAwaiting requested review from taehwanno
+1 more reviewer
@simsim0709simsim0709simsim0709 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hiddenest@taehwanno@taggon@simsim0709@hg-pyun