Translate code-splitting.md by liante0904 · Pull Request #55 · reactjs/ko.react.dev

liante0904 · 2019-02-28T16:02:53Z

Progress

번역 초안 작성(Draft translation)
공통 스타일 가이드 확인 (Check the common style guide)
용어 확인 (Check the term)
맞춤법 검사 (Spelling check)
리뷰 반영 (Resolve reviews)

netlify · 2019-02-28T16:10:39Z

Deploy preview for ko-reactjs-org ready!

Built with commit 12dbe01

https://deploy-preview-55--ko-reactjs-org.netlify.com

taehwanno · 2019-02-28T16:18:02Z

master에 모든 링크가 http -> https로 변경되어서 직접 충돌 해결했습니다.

ENvironmentSet

일단 제 몸을 가눌 수 있을 때 까지 리뷰를 해 보았습니다.
이 이후에도 몇몇 문제점이 보이는데, 잠시 자고 와서 다른 분들이 리뷰해주시지 않으셨다면 제가 달아드리겠습니다.

…ctjs.org into code-splitting # Conflicts: # content/docs/code-splitting.md

taehwanno · 2019-03-04T13:47:35Z

@liante0904 리뷰 사항 몇가지가 누락된 것 같아요. 코멘트가 많아서 아래처럼 "Load more"을 눌러야 추가적으로 더 보실 수 있을거에요. 확인 한번 부탁드려요.

gnujoow

띄어쓰기 오류가 있어 바로잡습니다.

taehwanno · 2019-03-06T16:07:41Z

변경된 링크에 대해 직접 충돌을 해결했습니다.

simsim0709 · 2019-03-15T11:25:15Z

-re-rendering the entire page at once so your users are unlikely to be
-interacting with other elements on the page at the same time.
+이를 시작하기 좋은 장소는 경로(routes)입니다. 웹 페이지를 불러오는 시간은 페이지 전환에 어느 정도 발생하며 대부분 페이지를 한번에 렌더링하기 때문에
+사용자가 페이지를 렌더링하는 동안 다른 요소와 상호작용하지 않습니다.


route는 번역하지 않고 라우트로 사용 하는게 어떨까요? 경로라고 번역되니 의미가 잘 전달되지 않는 것 같아서요.
@taehwanno

@simsim0709 express.js 번역도 라우팅으로 되어 있는 걸 보니 무리는 없을 것 같네요. 고민하다가 경로 리뷰 드렸는데 라우트로 변경에 동의합니다 :)
@liante0904 변경 부탁드릴게요!

@taehwanno @simsim0709경로(routes)에서 라우트 로 변경하면 될까요?
하단 Route-based code splitting 항목에서 how to setup route-based code splitting 를 경로 기반으로 번역하였는데 이 경우도 라우트 기반으로 변경하면 될지 확인하고 수정 commit 하려고 합니다.

@liante0904 네 맞습니다 :) 🚀

추가 될 -> 추가될로 제가 직접 수정 했습니다.

simsim0709 · 2019-03-26T03:57:09Z

@taehwanno 님이 이미 리뷰 accept 한 상태였고, @gnujoow 님이 요청한 수정사항 제가 직접 수정해서 pr 머지 하겠습니다.

simsim0709 · 2019-03-26T03:58:05Z

@liante0904 님 수고하셨습니다! 👍

Translate code-splitting.md to Kor.
3e5d87d

tesseralis mentioned this pull request Feb 28, 2019
Korean Translation Progress #1
Open

Merge branch 'master' into code-splitting
b0a5eac

taehwanno added the needs review label Feb 28, 2019

ENvironmentSet suggested changes Mar 1, 2019
View reviewed changes

Comment threadcontent/docs/code-splitting.md Outdated
Comment threadcontent/docs/code-splitting.md Outdated
Comment threadcontent/docs/code-splitting.md Outdated
Comment threadcontent/docs/code-splitting.md Outdated

liante0904and others added 4 commits March 2, 2019 22:11

Merge branch 'master' into code-splitting
4738df2

Apply review feedback
c1cbc9c

Merge branch 'code-splitting' ofhttps://github.com/liante0904/ko.rea…
91a24f8
…ctjs.org into code-splitting # Conflicts: # content/docs/code-splitting.md

Apply feedback, Fix unnatural translation.
491882e

taehwanno reviewed Mar 3, 2019
View reviewed changes

taehwanno added needs author response and removed needs review labels Mar 3, 2019

Apply feedback.
d841c75

Apply hide feedback.
e82f6da

taehwanno reviewed Mar 5, 2019
View reviewed changes

Comment threadcontent/docs/code-splitting.md Outdated
Comment threadcontent/docs/code-splitting.md Outdated
Comment threadcontent/docs/code-splitting.md Outdated

taehwanno added needs +1 approval and removed needs author response labels Mar 5, 2019

Fix router translation.
ccc830d

gnujoow requested changes Mar 6, 2019
View reviewed changes

Comment threadcontent/docs/code-splitting.md Outdated

gnujoow requested changes Mar 6, 2019
View reviewed changes

gnujoow added needs author response and removed needs +1 approval labels Mar 6, 2019

gnujoow previously requested changes Mar 6, 2019
View reviewed changes

Comment threadcontent/docs/code-splitting.md Outdated

liante0904and others added 3 commits March 6, 2019 21:44

Apply spacing words feedback.
00bae2c

Change words, polish.
2c267de

Merge branch 'master' into code-splitting
ac82f81

taehwanno previously approved these changes Mar 6, 2019
View reviewed changes

taehwanno added needs +1 approval and removed needs author response labels Mar 6, 2019

simsim0709 reviewed Mar 15, 2019
View reviewed changes

Apply feedback on the translation of the routes and route-based.
186c815

liante0904 dismissed taehwanno’s stale review via 186c815March 17, 2019 03:33

taehwanno previously approved these changes Mar 17, 2019
View reviewed changes

Update code-splitting.md
602e491

simsim0709 dismissed taehwanno’s stale review via 602e491March 26, 2019 03:55

Merge branch 'master' into code-splitting
12dbe01

simsim0709 merged commit 68563bd into reactjs:masterMar 26, 2019

taehwanno removed the needs +1 approval label Mar 26, 2019

taehwanno mentioned this pull request May 23, 2019
Translate FAQ > File Structure #107
Merged
6 tasks

Uh oh!

Conversation

liante0904 commented Feb 28, 2019• edited by gnujoow Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Uh oh!

netlifyBot commented Feb 28, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taehwanno commented Feb 28, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ENvironmentSet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

taehwanno commented Mar 4, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gnujoow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

taehwanno commented Mar 6, 2019

Uh oh!

simsim0709Mar 15, 2019

Choose a reason for hiding this comment

Uh oh!

taehwannoMar 16, 2019

Choose a reason for hiding this comment

Uh oh!

liante0904Mar 16, 2019

Choose a reason for hiding this comment

Uh oh!

taehwannoMar 16, 2019

Choose a reason for hiding this comment

Uh oh!

simsim0709 commented Mar 26, 2019

Uh oh!

simsim0709 commented Mar 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

liante0904 commented Feb 28, 2019•
edited by gnujoow
Loading

netlifyBot commented Feb 28, 2019•
edited
Loading