Skip to content

Translate Rules of Hooks - #63

Merged
simsim0709 merged 12 commits into
reactjs:masterfrom
BeomyeonAndrewKim:hooks-rules
Mar 22, 2019
Merged

Translate Rules of Hooks#63
simsim0709 merged 12 commits into
reactjs:masterfrom
BeomyeonAndrewKim:hooks-rules

Conversation

@BeomyeonAndrewKim

@BeomyeonAndrewKimBeomyeonAndrewKim commented Mar 4, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@netlify

netlifyBot commented Mar 4, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ko-reactjs-org ready!

Built with commit d6ab00c

https://deploy-preview-63--ko-reactjs-org.netlify.com

@tesseralistesseralis mentioned this pull request Mar 4, 2019
Open
gnujoow
gnujoow previously requested changes Mar 6, 2019
View reviewed changes

@gnujoowgnujoow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞춤법 오류가 있어 바로 잡습니다. ;)

Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
@BeomyeonAndrewKim

BeomyeonAndrewKim commented Mar 6, 2019

Copy link
Copy Markdown
ContributorAuthor

@gnujoow 수정 완료했습니다. 리뷰 감사합니다 :)

gnujoow
gnujoow reviewed Mar 6, 2019
View reviewed changes
Comment threadcontent/docs/hooks-rules.md Outdated
taggon
taggon reviewed Mar 6, 2019
View reviewed changes
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
@BeomyeonAndrewKim

BeomyeonAndrewKim commented Mar 8, 2019

Copy link
Copy Markdown
ContributorAuthor

@taggon@gnujoow 리뷰 및 제안 주셔서 감사합니다. 수정 완료했습니다 :)

hg-pyun
hg-pyun approved these changes Mar 21, 2019
View reviewed changes

@hg-pyunhg-pyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simsim0709
simsim0709 self-requested a review March 22, 2019 01:46
simsim0709
simsim0709 approved these changes Mar 22, 2019
View reviewed changes

@simsim0709simsim0709 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~ 👍

@simsim0709
simsim0709 dismissed gnujoow’s stale reviewMarch 22, 2019 01:47

수정 확인되어 제가 머지하겠습니다.

@simsim0709
simsim0709 merged commit d49f15a into reactjs:masterMar 22, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taggontaggontaggon left review comments
@gnujoowgnujoowgnujoow left review comments
@hg-pyunhg-pyunhg-pyun approved these changes
+1 more reviewer
@simsim0709simsim0709simsim0709 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@BeomyeonAndrewKim@taggon@simsim0709@hg-pyun@gnujoow@taehwanno@BeomyeonKim