Skip to content

Translate render-props - #73

Merged
simsim0709 merged 16 commits into
reactjs:masterfrom
hg-pyun:master
Apr 17, 2019
Merged

Translate render-props#73
simsim0709 merged 16 commits into
reactjs:masterfrom
hg-pyun:master

Conversation

@hg-pyun

@hg-pyunhg-pyun commented Mar 16, 2019•
edited
Loading

Copy link
Copy Markdown
Member

@tesseralistesseralis mentioned this pull request Mar 16, 2019
Open
@hg-pyunhg-pyun assigned hg-pyun and unassigned hg-pyunMar 16, 2019
@netlify

netlifyBot commented Mar 16, 2019

Copy link
Copy Markdown

Deploy preview for ko-reactjs-org ready!

Built with commit bfbd215

https://deploy-preview-73--ko-reactjs-org.netlify.com

@netlify

netlifyBot commented Mar 16, 2019

Copy link
Copy Markdown

Deploy preview for ko-reactjs-org ready!

Built with commit c09fed5

https://deploy-preview-73--ko-reactjs-org.netlify.com

@netlify

netlifyBot commented Mar 16, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ko-reactjs-org ready!

Built with commit 2d4309d

https://deploy-preview-73--ko-reactjs-org.netlify.com

cadenzah
cadenzah reviewed Mar 30, 2019
View reviewed changes
Comment threadcontent/docs/render-props.md Outdated
cadenzah
cadenzah reviewed Mar 30, 2019
View reviewed changes
Comment threadcontent/docs/render-props.md Outdated
cadenzah
cadenzah reviewed Mar 30, 2019
View reviewed changes
Comment threadcontent/docs/render-props.md Outdated
cadenzah
cadenzah reviewed Mar 31, 2019
View reviewed changes
Comment threadcontent/docs/render-props.md Outdated
cadenzah
cadenzah reviewed Mar 31, 2019
View reviewed changes
Comment threadcontent/docs/render-props.md Outdated
simsim0709
simsim0709 reviewed Apr 8, 2019
View reviewed changes
Comment threadcontent/docs/render-props.md Outdated
simsim0709
simsim0709 reviewed Apr 8, 2019
View reviewed changes
Comment threadcontent/docs/render-props.md Outdated
simsim0709
simsim0709 reviewed Apr 8, 2019
View reviewed changes
Comment threadcontent/docs/render-props.md Outdated
예를 들어, 마우스 주위에 고양이 그림을 보여주는 `<Cat>` 컴포넌트를 생각해 보겠습니다. 우리는 `<Cat mouse={{x, y}}>` prop을 통해 Cat 컴포넌트에 마우스 좌표를 전달해주고 화면에 어떤 위치에 이미지를 보여줄지 알려 주고자 합니다.

As a first pass, you might try rendering the `<Cat>` *inside `<Mouse>`'s `render` method*, like this:
첫 번째 방법으로는, 다음과 같이 `<Mouse>` 컴포넌트의 *render 메서드안에* `<Cat>` 컴포넌트를 넣어 렌더링하는 방법이 있습니다:

@simsim0709simsim0709Apr 8, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"있습니다:" -> "있습니다." 콜론 제거되야 할 것 같습니다.

@hg-pyunhg-pyunApr 8, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이부분은 원문을 살려 :를 표현했는데 어느게 좋을까요?
다른 부분에서도 동일하게 컨벤션을 맞추고 있습니다.
image

@simsim0709simsim0709Apr 9, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 메인테이너 분들 의견 들어 보는게 좋을 것 같습니다! @taehwanno@taggon@gnujoow

@gnujoowgnujoowApr 11, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:는 제거하는것이 best practice로 제안되어있습니다. 제거하는것이 컨벤션을 유지하는데 좋을것 같아요

@gnujoowgnujoowApr 11, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref https://github.com/reactjs/ko.reactjs.org/wiki/Best-practices-for-translation

@hg-pyunhg-pyunApr 12, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnujoow 의견 감사합니다 :D

@hg-pyunhg-pyunApr 12, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했습니다 ( _ _ )

simsim0709
simsim0709 reviewed Apr 8, 2019
View reviewed changes
Comment threadcontent/docs/render-props.md Outdated
simsim0709
simsim0709 reviewed Apr 8, 2019
View reviewed changes
Comment threadcontent/docs/render-props.md Outdated
simsim0709
simsim0709 reviewed Apr 8, 2019
View reviewed changes
Comment threadcontent/docs/render-props.md Outdated
simsim0709
simsim0709 reviewed Apr 8, 2019
View reviewed changes
Comment threadcontent/docs/render-props.md Outdated
@gnujoow

gnujoow commented Apr 11, 2019

Copy link
Copy Markdown
Member

#73 (review)
만 resolve되면 바로 merge해도 될것 같습니다.

@hg-pyun

hg-pyun commented Apr 14, 2019

Copy link
Copy Markdown
MemberAuthor

@gnujoow@simsim0709@cadenzah 확인 부탁드려요:)

@simsim0709
simsim0709 self-requested a review April 14, 2019 12:28
simsim0709
simsim0709 approved these changes Apr 14, 2019
View reviewed changes

@simsim0709simsim0709 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~ 👍

cadenzah
cadenzah approved these changes Apr 14, 2019
View reviewed changes

@cadenzahcadenzah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! :)

@hg-pyun

hg-pyun commented Apr 16, 2019

Copy link
Copy Markdown
MemberAuthor

머지 부탁드려요 ㅎㅎ

@simsim0709
simsim0709 merged commit d21d361 into reactjs:masterApr 17, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnujoowgnujoowgnujoow left review comments
+2 more reviewers
@simsim0709simsim0709simsim0709 approved these changes
@cadenzahcadenzahcadenzah approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hg-pyun@gnujoow@simsim0709@cadenzah