Skip to content

Translate Home Page - #8

Merged
hg-pyun merged 2 commits into
reactjs:masterfrom
chatoo2412:translate/home
Feb 13, 2019
Merged

Translate Home Page#8
hg-pyun merged 2 commits into
reactjs:masterfrom
chatoo2412:translate/home

Conversation

@chatoo2412

@chatoo2412chatoo2412 commented Feb 9, 2019

Copy link
Copy Markdown
Contributor

@chatoo2412chatoo2412 mentioned this pull request Feb 9, 2019
Open
gnujoow
gnujoow reviewed Feb 9, 2019
View reviewed changes

@gnujoowgnujoow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a my translation suggestion for the first sentence and punctuation mistake as a comment.

others are looks good to me ;)

Comment threadcontent/home/examples/a-component-using-external-plugins.md Outdated
Comment threadcontent/home/examples/an-application.md Outdated
taehwanno
taehwanno reviewed Feb 9, 2019
View reviewed changes

@taehwannotaehwanno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍

Comment threadcontent/home/marketing/declarative.md Outdated
ENvironmentSet
ENvironmentSet reviewed Feb 9, 2019
View reviewed changes

@ENvironmentSetENvironmentSet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked your translation, and it looks great to me. but I feel something lacking(just a little), could you check my suggestion and comment about it?

Comment threadcontent/home/examples/a-component-using-external-plugins.md Outdated
Comment threadcontent/home/examples/a-simple-component.md Outdated
taggon
taggon reviewed Feb 9, 2019
View reviewed changes
Comment threadcontent/home/examples/a-simple-component.md Outdated
@chatoo2412
chatoo2412force-pushed the translate/home branch 3 times, most recently from 835d06c to 4226b74CompareFebruary 10, 2019 06:18
hg-pyun
hg-pyun reviewed Feb 10, 2019
View reviewed changes
Comment threadcontent/home/marketing/learn-once-write-anywhere.md Outdated
taggon
taggon reviewed Feb 10, 2019
View reviewed changes
Comment threadcontent/home/marketing/declarative.md Outdated
Comment threadcontent/home/marketing/learn-once-write-anywhere.md Outdated
Comment threadcontent/home/examples/a-component-using-external-plugins.md Outdated
Comment threadcontent/home/examples/a-simple-component.md Outdated
@taehwanno

taehwanno commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

@chatoo2412 Could you please resolve conflict?

@hg-pyunhg-pyun self-assigned this Feb 11, 2019
@hg-pyun

hg-pyun commented Feb 11, 2019

Copy link
Copy Markdown
Member

@ALL
If review is done, please approved.

@hg-pyunhg-pyun removed their assignment Feb 11, 2019
@tesseralis

tesseralis commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

@taehwanno are we ready to merge this in?

@taehwanno

taehwanno commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

@tesseralis Yes, I think so. but I'm waiting for the approval of other reviewers who participated.

@tesseralis

tesseralis commented Feb 13, 2019

Copy link
Copy Markdown
Contributor

@taehwanno I think it's a good idea to come up with a system for reviews. After all, you can't expect everyone listed as a reviewer to look over it!

Do you want only one person to approve before merging or two? This has two approvals, so are you and @hg-pyun ready to merge this in?

@hg-pyun

hg-pyun commented Feb 13, 2019•
edited
Loading

Copy link
Copy Markdown
Member

@tesseralis

  1. Review comment is all reset.
  2. If more than two main member are approved

I think it's good to merge.

@hg-pyun
hg-pyun merged commit c42b253 into reactjs:masterFeb 13, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taggontaggontaggon left review comments
@gnujoowgnujoowgnujoow left review comments
@hg-pyunhg-pyunhg-pyun approved these changes
@simsim0709simsim0709Awaiting requested review from simsim0709
+3 more reviewers
@SeonHyungJoSeonHyungJoSeonHyungJo left review comments
@ENvironmentSetENvironmentSetENvironmentSet left review comments
@taehwannotaehwannotaehwanno approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@chatoo2412@taehwanno@hg-pyun@tesseralis@taggon@gnujoow@SeonHyungJo@ENvironmentSet