Skip to content

Translate HOOKS > Hooks API Reference - #89

Merged
taehwanno merged 12 commits into
reactjs:masterfrom
hapumee:master
Apr 28, 2019
Merged

Translate HOOKS > Hooks API Reference#89
taehwanno merged 12 commits into
reactjs:masterfrom
hapumee:master

Conversation

@hapumee

@hapumeehapumee commented Apr 2, 2019•
edited by hg-pyun
Loading

Copy link
Copy Markdown
Contributor

@hapumeehapumee changed the title Draft translationTranslate HOOKS > Hooks API ReferenceApr 2, 2019
@netlify

netlifyBot commented Apr 2, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ko-reactjs-org ready!

Built with commit 69c6a8f

https://deploy-preview-89--ko-reactjs-org.netlify.com

@tesseralistesseralis mentioned this pull request Apr 2, 2019
Open
@hapumee

hapumee commented Apr 3, 2019

Copy link
Copy Markdown
ContributorAuthor

I'm not sure how I can translate the terms below.
If there are words which have already been decided for them, just let me know.
I'm gonna fix them.

  • effect : effect
  • clean-up/ clean-up function : 정화 함수
  • flush : 해결, 발생
  • memoization : 메모화, 저장화
  • signature : 시그니처
  • mutation : 변경
  • fire : 발생하다
  • DevTools : 개발자도구
  • mutable : 변경 가능한, 가변의
  • customize : 사용자화하다
  • lazy : 지연
  • reducer : reducer

simsim0709
simsim0709 reviewed Apr 11, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 11, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 11, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
@youngsunmin
[review#1]
597320d
1) line 13 "혹 Hook이" -> "Hook이"
2) line 52 "함수 갱신" -> "함수적 갱신"
simsim0709
simsim0709 reviewed Apr 12, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 12, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 12, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 12, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 12, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 12, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 12, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md
simsim0709
simsim0709 reviewed Apr 12, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
youngsunminand others added 2 commits April 12, 2019 14:33
@youngsunmin
[review 2]
4c32d11
1) line 74
2) line 83
3) line 87
4) line 98
5) line 108
@simsim0709
Merge branch 'master' into master
b91d379
simsim0709
simsim0709 reviewed Apr 17, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 17, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 17, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 17, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 17, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 23, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 23, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 23, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 23, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 23, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 23, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 23, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 23, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 23, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 23, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
simsim0709
simsim0709 reviewed Apr 23, 2019
View reviewed changes
Comment threadcontent/docs/hooks-reference.md Outdated
@simsim0709

simsim0709 commented Apr 23, 2019

Copy link
Copy Markdown
Contributor

리뷰 다 마쳤습니다. 확인 부탁드려요. 😄

@simsim0709
simsim0709 self-requested a review April 24, 2019 08:17
simsim0709
simsim0709 approved these changes Apr 24, 2019
View reviewed changes

@simsim0709simsim0709 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정말 수고 많으셨어요~ 👍

@hapumee

hapumee commented Apr 24, 2019

Copy link
Copy Markdown
ContributorAuthor

커맨트 주신 부분 모두 반영하였습니다.
"needs author response"로 label이 변경되어, 커맨트 conversation은 제가 resolve 했습니다. : )

다만, 한 가지, line 195에 대한 의견을 드렸는데요,
한 번 확인 부탁드릴께요. 보시고서 resolve 해 주시면 좋을 것 같습니다. : )

@hapumee

hapumee commented Apr 24, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

아.. 그렇다면 하나 남아 있던 conversation도 제가 resolve 하겠습니다. ^_________^

좋은 논의였습니다. 감사합니다. : )

hg-pyun
hg-pyun approved these changes Apr 24, 2019
View reviewed changes

@hg-pyunhg-pyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

@taehwanno
taehwanno merged commit 0912d04 into reactjs:masterApr 28, 2019
@taehwanno

taehwanno commented Apr 28, 2019

Copy link
Copy Markdown
Contributor

고생하셨습니다!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hg-pyunhg-pyunhg-pyun approved these changes
@taehwannotaehwannoAwaiting requested review from taehwanno
+1 more reviewer
@simsim0709simsim0709simsim0709 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hapumee@simsim0709@taehwanno@hg-pyun@youngsunmin