Skip to content

Translate Hello world - #9

Merged
taehwanno merged 13 commits into
reactjs:masterfrom
chayeoi:hello-world
Feb 19, 2019
Merged

Translate Hello world#9
taehwanno merged 13 commits into
reactjs:masterfrom
chayeoi:hello-world

Conversation

@chayeoi

@chayeoichayeoi commented Feb 9, 2019

Copy link
Copy Markdown
Collaborator

Added translation to Hello World section.
Please let me know if you find any mistakes.

chayeoi added 3 commits February 9, 2019 13:44
chayeoi
Translate Hello World
1fe1981
chayeoi
Fix typo
803a856
chayeoi
Fix typo
83f997e
네비게이션 => 내비게이션
taggon
taggon reviewed Feb 9, 2019
View reviewed changes
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
taehwanno
taehwanno reviewed Feb 9, 2019
View reviewed changes
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
@tesseralistesseralis mentioned this pull request Feb 9, 2019
Open
@simsim0709
simsim0709 self-requested a review February 9, 2019 15:30
taehwanno
taehwanno reviewed Feb 9, 2019
View reviewed changes
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md
SeonHyungJo
SeonHyungJo reviewed Feb 9, 2019
View reviewed changes
Comment threadcontent/docs/hello-world.md Outdated
@taehwannotaehwanno mentioned this pull request Feb 11, 2019
Closed
taehwanno
taehwanno reviewed Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/hello-world.md Outdated
taehwanno
taehwanno reviewed Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/hello-world.md
## 이 안내서를 읽는 방법 {#how-to-read-this-guide}

In this guide, we will examine the building blocks of React apps: elements and components. Once you master them, you can create complex apps from small reusable pieces.
이 안내서에서 우리는 엘리먼트와 컴포넌트라고 불리는 React 앱의 구성 블록들에 대해 살펴볼 것입니다. 이들을 숙달하고 나면 재사용 가능한 조각들로부터 복잡한 앱을 만들 수도 있습니다.

@taehwannotaehwannoFeb 12, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

building block 번역에 대한 논의가 필요해보여요. #2 (comment)

Comment threadcontent/docs/hello-world.md Outdated
@chayeoichayeoi mentioned this pull request Feb 13, 2019
Merged
@taehwanno

taehwanno commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

@chayeoi 가장 최근에 남긴 리뷰 코멘트에 대한 변경사항이 푸쉬되지 않은거 같아요. 확인 부탁드릴게요 :)

@chayeoi

chayeoi commented Feb 14, 2019•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

@taehwanno 푸시를 안 했었네요..! 방금 다시 했습니다 :)

@taehwanno
taehwanno merged commit bdb803d into reactjs:masterFeb 19, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taggontaggontaggon left review comments
@hg-pyunhg-pyunhg-pyun approved these changes
@simsim0709simsim0709Awaiting requested review from simsim0709
+2 more reviewers
@SeonHyungJoSeonHyungJoSeonHyungJo left review comments
@taehwannotaehwannotaehwanno approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chayeoi@taehwanno@taggon@simsim0709@hg-pyun@SeonHyungJo