Skip to content

Ajuste do Menu e tradução dos menus laterais - #135

Merged
jhonmike merged 10 commits into
reactjs:masterfrom
jhonmike:fix-menus
Mar 6, 2019
Merged

Ajuste do Menu e tradução dos menus laterais#135
jhonmike merged 10 commits into
reactjs:masterfrom
jhonmike:fix-menus

Conversation

@jhonmike

@jhonmikejhonmike commented Feb 28, 2019•
edited
Loading

Copy link
Copy Markdown
Member

image
image
image

@jhonmikejhonmike mentioned this pull request Feb 28, 2019
Closed
@netlify

netlifyBot commented Feb 28, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for pt-br-reactjs ready!

Built with commit 643e8d7

https://deploy-preview-135--pt-br-reactjs.netlify.com

@jhonmikejhonmike changed the title Ajuste do Menu e tradução do menu lateral da seção comunidade.Ajuste do Menu e tradução dos menus lateraisFeb 28, 2019
glaucia86
glaucia86 suggested changes Mar 3, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhonmike faz as alterações listadas que aprovarei e farei o merge para a documentação principal.

Muito obrigada pela sua contribuição! :)

Comment threadcontent/community/nav.yml Outdated
Comment threadcontent/docs/nav.yml Outdated
Comment threadcontent/docs/nav.yml Outdated
@glaucia86glaucia86 added needs review A pull request ready to be reviewed needs author response Changes requested needing author's input labels Mar 3, 2019
glaucia86and others added 3 commits March 3, 2019 10:50
@glaucia86jhonmike
Update content/community/nav.yml
144c179
Co-Authored-By: jhonmike <developer@jhonmike.com.br>
@glaucia86jhonmike
Update content/docs/nav.yml
1e3b684
Co-Authored-By: jhonmike <developer@jhonmike.com.br>
Jhon Mike
adjustment in navigation title
1694d88
@jhonmikejhonmike removed the needs author response Changes requested needing author's input label Mar 3, 2019
@halian-vilela

halian-vilela commented Mar 4, 2019

Copy link
Copy Markdown
Contributor

@jhonmike
Já fez o commit resolvendo a questão do espaçamento? Se sim, acho que o resto já está ok né?

Podemos fazer o merge?

cc:@glaucia86

@glaucia86

glaucia86 commented Mar 5, 2019

Copy link
Copy Markdown
Contributor

@jhonmike
Já fez o commit resolvendo a questão do espaçamento? Se sim, acho que o resto já está ok né?

Podemos fazer o merge?

cc:@glaucia86

No aguardo da resposta do @jhonmike

@glaucia86glaucia86 added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Mar 5, 2019
@lffglffg mentioned this pull request Mar 5, 2019
Closed
@jhonmike

jhonmike commented Mar 6, 2019

Copy link
Copy Markdown
MemberAuthor

@halian-vilela@glaucia86 sim já fiz os ajustes, estava mesmo esperando a aprovação do PR haha :)

@jhonmikejhonmike added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Mar 6, 2019
@jhonmikejhonmike mentioned this pull request Mar 6, 2019
Merged
glaucia86
glaucia86 approved these changes Mar 6, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhonmike muito obrigada pela sua contribuição!

LGTM 👍

@glaucia86

glaucia86 commented Mar 6, 2019

Copy link
Copy Markdown
Contributor

cc: @halian-vilela só aprovar e mergear esse PR :)

@jhonmikejhonmike added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Mar 6, 2019
@jhonmike

jhonmike commented Mar 6, 2019

Copy link
Copy Markdown
MemberAuthor

Vou dar "Merge" pois, este PR corrige o bug no menu duplicado que já esta no ar.

@jhonmike
jhonmike merged commit e252674 into reactjs:masterMar 6, 2019
@tesseralistesseralis mentioned this pull request Mar 7, 2019
Closed
90 tasks
devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
Jhon Mike
Ajuste do Menu e tradução dos menus laterais (reactjs#135)
3d685fa
* remove dublicate menu in header component
* translate docs navbar
* translate title docs menu lateral
* adjusted items not translated in navigation documentation
* translated article navigation
* Update content/community/nav.yml
Co-Authored-By: jhonmike <developer@jhonmike.com.br>
* Update content/docs/nav.yml
Co-Authored-By: jhonmike <developer@jhonmike.com.br>
* adjustment in navigation title
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eduardomoronieduardomoroniAwaiting requested review from eduardomoroni
1 more reviewer
@glaucia86glaucia86glaucia86 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🌐 translatedTranslation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jhonmike@halian-vilela@glaucia86