Skip to content

Translate of react blog post react v15.6.2 - #200

Merged
jhonmike merged 3 commits into
reactjs:masterfrom
netochaves:translate-of-blog-post-react-v15.6.2
Apr 16, 2019
Merged

Translate of react blog post react v15.6.2#200
jhonmike merged 3 commits into
reactjs:masterfrom
netochaves:translate-of-blog-post-react-v15.6.2

Conversation

@netochaves

@netochavesnetochaves commented Apr 10, 2019

Copy link
Copy Markdown
Contributor

+1 #151

@netochavesnetochaves mentioned this pull request Apr 10, 2019
Closed
45 tasks
@netlify

netlifyBot commented Apr 10, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for pt-br-reactjs ready!

Built with commit cc5e0fd

https://deploy-preview-200--pt-br-reactjs.netlify.com

@netochaves

netochaves commented Apr 11, 2019

Copy link
Copy Markdown
ContributorAuthor

Eu fiz a PR antes de fazer a verificação com o yarn, my bad 😞.
Ao fazer a verificação deu o seguinte erro:

/home/dct/pt-BR.reactjs.org/src/templates/blog.js
43:26 error Syntax Error blog.js (18:33) Invalid character escape sequence: \d.
17: fields {
18: date(formatString: "DD \d\e MMMM \d\e YYYY", locale: "pt-br")
^
19: path
relay/graphql-syntax
✖ 1 problem (1 error, 0 warnings)
error Command failed with exit code 1.

Alguém tem idea do que pode ser?

@jhonmikejhonmike added blog Blog post translation needs review A pull request ready to be reviewed labels Apr 11, 2019
@jhonmike

jhonmike commented Apr 11, 2019

Copy link
Copy Markdown
Member

acho q ao atualizar o branch o erro sumiu, ou ainda persiste?

@netochaves

netochaves commented Apr 11, 2019

Copy link
Copy Markdown
ContributorAuthor

acho q ao atualizar o branch o erro sumiu, ou ainda persiste?

Continua o erro, apesar de o netlify ter passado todos os testes. Eu atualizei a branch localmente mas nada, estranho o.o

@jhonmike

jhonmike commented Apr 11, 2019

Copy link
Copy Markdown
Member

@netochaves rodei aqui o yarn, yarn dev, yarn build e não deu erro

@netochaves

netochaves commented Apr 11, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@jhonmike rodou o yarn check-all?

@jhonmike

jhonmike commented Apr 11, 2019

Copy link
Copy Markdown
Member

Oouu de fato esta dando erro :(, vou verificar aqui, pois, parece que este erro não é de agora!!

@netochaves

netochaves commented Apr 11, 2019

Copy link
Copy Markdown
ContributorAuthor

certo

@jhonmike

jhonmike commented Apr 11, 2019

Copy link
Copy Markdown
Member

Andei pesquisando e não achei nada sobre essa validação do linter, mas pensaria em tentar a seguinte proposta:

date(formatString: "DD/MM/YYYY",locale: "pt-br")

acho q seria uma boa, mas se tu for fazer, acho legal abrir um novo PR com esse ajustes, explicando o problema que tivemos, se estiver sem tempo, eu abro mais tarde o PR

@netochaves

netochaves commented Apr 11, 2019

Copy link
Copy Markdown
ContributorAuthor

No momento estou sem tempo mas esse erro já estava acontecendo anteriormente? porque não alterei esse arquivo.

@jhonmike

jhonmike commented Apr 11, 2019

Copy link
Copy Markdown
Member

Sim, aparentemente deixamos passar, por isso não se preocupe neste PR, vamos continuar o Code Review, mas podemos ajustar em um novo PR e discutir qual será a melhor solução!!

@netochaves

netochaves commented Apr 11, 2019

Copy link
Copy Markdown
ContributorAuthor

Ok, quando estiver com tempo posso dar uma estudada melhor no erro caso ele ainda não tenha sido resolvido.

jhonmike
jhonmike reviewed Apr 15, 2019
View reviewed changes

@jhonmikejhonmike left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apenas um pequeno ajuste 👏

Comment threadcontent/blog/2017-09-25-react-v15.6.2.md Outdated
@jhonmikejhonmike added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Apr 15, 2019
Jhon Mike@netochaves
Update content/blog/2017-09-25-react-v15.6.2.md
cc5e0fd
Co-Authored-By: netochaves <netobac1@gmail.com>
@netochavesnetochaves changed the title translate of react blog post react v15.6.2Translate of react blog post react v15.6.2Apr 15, 2019
@netochaves

netochaves commented Apr 15, 2019

Copy link
Copy Markdown
ContributorAuthor

Obrigado pelas review @jhonmike

@jhonmikejhonmike added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input labels Apr 16, 2019
@jhonmike
jhonmike merged commit a397a57 into reactjs:masterApr 16, 2019
devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@netochavesJhon Mike
Translate of react blog post react v15.6.2 (reactjs#200)
63fa679
* translate of react blog post react v15.6.2
* Update content/blog/2017-09-25-react-v15.6.2.md
Co-Authored-By: netochaves <netobac1@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhonmikejhonmikejhonmike approved these changes

Assignees

No one assigned

Labels

blogBlog post translation🌐 translatedTranslation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@netochaves@jhonmike