Skip to content

Special props translation - #28

Merged
fjoshuajr merged 8 commits into
reactjs:masterfrom
andrescalco:special-props-translation
Feb 9, 2019
Merged

Special props translation#28
fjoshuajr merged 8 commits into
reactjs:masterfrom
andrescalco:special-props-translation

Conversation

@andrescalco

@andrescalcoandrescalco commented Feb 9, 2019

Copy link
Copy Markdown
Contributor

glaucia86
glaucia86 suggested changes Feb 9, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrescalco pequenas alterações a serem feitas. Altere agora que já aprovo esse PR. ;)

Comment threadcontent/warnings/special-props.md Outdated
Comment threadcontent/warnings/special-props.md Outdated
@glaucia86glaucia86 added the needs review A pull request ready to be reviewed label Feb 9, 2019
@glaucia86@andrescalco
Update content/warnings/special-props.md
333a875
Co-Authored-By: andrescalco <andre@andrescalco.com>
glaucia86
glaucia86 previously approved these changes Feb 9, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cc: @cezaraugusto@WendellAdriel it's a short translation. Can we approve this PR?

@glaucia86glaucia86 added the needs +1 Needs another approval before merging label Feb 9, 2019
@andrescalco

andrescalco commented Feb 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Prontinho! Amanhã acho que consigo pegar mais alguns dos warnings e traduzí-los XD

eduardomoroni
eduardomoroni previously requested changes Feb 9, 2019
View reviewed changes

@eduardomoronieduardomoroni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algumas sugestões @andrescalco, caso não ache relevante me da o toque que a gente mergeia. :)

Comment threadcontent/warnings/special-props.md Outdated
Comment threadcontent/warnings/special-props.md Outdated
@eduardomoronieduardomoroni added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging needs review A pull request ready to be reviewed labels Feb 9, 2019
@andrescalco

andrescalco commented Feb 9, 2019

Copy link
Copy Markdown
ContributorAuthor

@eduardomoroni as sugestões fazem sentido sim! Vou alterar e fazer o commit.

@glaucia86 seria interessante lá na #1 fazer o assign dessa tradução para mim,não acha?

@andrescalco

andrescalco commented Feb 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Meu último commit não tinha as alterções da @glaucia86. Agora está tudo certo XD

fjoshuajr
fjoshuajr suggested changes Feb 9, 2019
View reviewed changes

@fjoshuajrfjoshuajr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veja estas sugestões por favor.

Comment threadcontent/warnings/special-props.md Outdated
@fjoshuajr@andrescalco
Update content/warnings/special-props.md
da38a48
Co-Authored-By: andrescalco <andre@andrescalco.com>
cezaraugusto
cezaraugusto approved these changes Feb 9, 2019
View reviewed changes

@cezaraugustocezaraugusto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cezaraugustocezaraugusto added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 9, 2019
@fjoshuajr
fjoshuajr dismissed eduardomoroni’s stale reviewFebruary 9, 2019 21:46

Feedback addressed 👌

@fjoshuajr
fjoshuajr merged commit e8b79aa into reactjs:masterFeb 9, 2019
@fjoshuajrfjoshuajr added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Feb 9, 2019
@tesseralistesseralis mentioned this pull request Feb 9, 2019
Closed
90 tasks
devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@andrescalco@fjoshuajr
Special props translation (reactjs#28)
340f250
* Add pt-BR translation to the special-props page
* Fix typos
* Update content/warnings/special-props.md
Co-Authored-By: andrescalco <andre@andrescalco.com>
* Update special-props.md
* Add small changes
* Add small changes
* Update content/warnings/special-props.md
Co-Authored-By: andrescalco <andre@andrescalco.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers
@cezaraugustocezaraugustocezaraugusto approved these changes
@fjoshuajrfjoshuajrfjoshuajr approved these changes
@eduardomoronieduardomoronieduardomoroni left review comments
@glaucia86glaucia86glaucia86 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🌐 translatedTranslation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andrescalco@eduardomoroni@glaucia86@cezaraugusto@fjoshuajr