Uh oh!
There was an error while loading. Please reload this page.
Translate React API Reference - #31
Conversation
cezaraugusto
left a comment
There was a problem hiding this comment.
awesome translation @renato-bohler! I guess this is the biggest one so far.
I've left some comments with improvements I saw to make reading easier for PT-Br readers. They're not set in stone and up for debate if you like. Thanks for taking time to do this all!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
renato-bohler
commented
Feb 9, 2019
Hey @cezaraugusto I've just revised every change request you've made and I agree with most of it. I've left some comments on the others. As soon as we resolve all of these, I'll adjust everything and give it another read just to make sure. Thanks 😄 |
cezaraugusto
commented
Feb 9, 2019
thanks @renato-bohler! agree with your comments. btw for things we agreed at first there's a button where you can apply changes without manually editing them, but I guess you know that already |
renato-bohler
commented
Feb 9, 2019
Nice! I'm committing those now then. |
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
Co-Authored-By: renato-bohler <renato.bohler@gmail.com>
renato-bohler
commented
Feb 9, 2019
Done. There's only one still unresolved that I've decided to change a little bit. |
glaucia86
commented
Feb 10, 2019
Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'. |
renato-bohler
commented
Feb 10, 2019
@glaucia86 resolvi todas, mas aparentemente não consigo trocar o label do PR. |
eduardomoroni
commented
Feb 10, 2019
Qual label seria o correto para o caso em que o autor fez as mudanças requeridas pelos revisores? |
glaucia86
commented
Feb 10, 2019
a Laranja. Criei para nos sinalizar de que vocês já efetuaram as mudanças necessárias e voltar para essa task e aprovar as contribuições. |
glaucia86
left a comment
There was a problem hiding this comment.
@renato-bohler
LGTM 👍
Queremos agradecer pela sua excelente contribuição! Muito obrigada!
cezaraugusto
commented
Feb 10, 2019
@eduardomoroni geralmente eu removo o "needs author response" e adiciono de volta o "needs review". A etiqueta que a @glaucia86 criou é boa também |
renato-bohler
commented
Feb 10, 2019
Massa! Se precisarem de mais alguma tradução ou de um review, só dar um grito! |
* translate React API Reference * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md * Update content/docs/reference-react.md
No description provided.