Skip to content

Translate Shallow renderer - #32

Merged
glaucia86 merged 3 commits into
reactjs:masterfrom
henriquejensen:shallow-renderer-translation
Feb 10, 2019
Merged

Translate Shallow renderer#32
glaucia86 merged 3 commits into
reactjs:masterfrom
henriquejensen:shallow-renderer-translation

Conversation

@henriquejensen

@henriquejensenhenriquejensen commented Feb 9, 2019

Copy link
Copy Markdown
Contributor

@fjoshuajrfjoshuajr added the needs review A pull request ready to be reviewed label Feb 9, 2019
jhonmike
jhonmike reviewed Feb 9, 2019
View reviewed changes
Comment threadcontent/docs/addons-shallow-renderer.md
cezaraugusto
cezaraugusto suggested changes Feb 9, 2019
View reviewed changes

@cezaraugustocezaraugusto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @henriquejensen, left some comments

Comment threadcontent/docs/addons-shallow-renderer.md Outdated
Comment threadcontent/docs/addons-shallow-renderer.md Outdated
Comment threadcontent/docs/addons-shallow-renderer.md Outdated
@cezaraugustocezaraugusto added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 9, 2019
@henriquejensen

henriquejensen commented Feb 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Hey @cezaraugusto thanks for the feedback, I did the changes

cezaraugusto
cezaraugusto approved these changes Feb 9, 2019
View reviewed changes

@cezaraugustocezaraugusto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cezaraugustocezaraugusto added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 9, 2019
tibuurcio
tibuurcio reviewed Feb 9, 2019
View reviewed changes

@tibuurciotibuurcio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions basically about the use of afirmar to translate assert. Please tell me what you think about, completely open to discussion!

Thank you for taking the time 👍

Comment threadcontent/docs/addons-shallow-renderer.md
Comment threadcontent/docs/addons-shallow-renderer.md
Comment threadcontent/docs/addons-shallow-renderer.md
glaucia86
glaucia86 approved these changes Feb 10, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henriquejensen
LGTM 👍
Queremos agradecer pela sua excelente contribuição! Muito obrigada!

@glaucia86
glaucia86 merged commit 325762f into reactjs:masterFeb 10, 2019
@tesseralistesseralis mentioned this pull request Feb 10, 2019
Closed
90 tasks
@glaucia86glaucia86 removed the needs +1 Needs another approval before merging label Feb 10, 2019
@fjoshuajrfjoshuajr added the 🌐 translated Translation is completed for this page label Feb 10, 2019
devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@henriquejensen@glaucia86
Translate Shallow renderer (reactjs#32)
27a5265
* Translate Shallow Renderer to pt-BR
* Code Review fixes
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhonmikejhonmikejhonmike left review comments
+3 more reviewers
@tibuurciotibuurciotibuurcio left review comments
@glaucia86glaucia86glaucia86 approved these changes
@cezaraugustocezaraugustocezaraugusto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🌐 translatedTranslation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@henriquejensen@glaucia86@jhonmike@cezaraugusto@tibuurcio@fjoshuajr