Skip to content

Adjusting translation as discussed - #35

Merged
cezaraugusto merged 2 commits into
reactjs:masterfrom
halian-vilela:adjusting-translations
Feb 9, 2019
Merged

Adjusting translation as discussed#35
cezaraugusto merged 2 commits into
reactjs:masterfrom
halian-vilela:adjusting-translations

Conversation

@halian-vilela

Copy link
Copy Markdown
Contributor

Adjusting as stated in #10 (comment)

@cezaraugustocezaraugusto added the follow-up Changes applied in a previously translated file label Feb 9, 2019
cezaraugusto
cezaraugusto previously approved these changes Feb 9, 2019

@cezaraugustocezaraugusto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@cezaraugustocezaraugusto added the needs +1 Needs another approval before merging label Feb 9, 2019
@fjoshuajr

Copy link
Copy Markdown
Contributor

Looking good!

I'll wait for a consensus among the members about whether we should translate internal links or not.

@fjoshuajrfjoshuajr added the needs resolution Something not defined that needs maintainers input label Feb 9, 2019
@cezaraugusto

Copy link
Copy Markdown
Contributor

@fjoshuajr re link translation I created #42. I guess we're good to go with this one

@cezaraugustocezaraugusto removed the needs resolution Something not defined that needs maintainers input label Feb 9, 2019

@fjoshuajrfjoshuajr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@cezaraugusto
cezaraugusto merged commit 97aef45 into reactjs:masterFeb 9, 2019
@cezaraugustocezaraugusto added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging 🌐 translated Translation is completed for this page labels Feb 9, 2019
@fjoshuajrfjoshuajr added 🌐 translated Translation is completed for this page and removed 🌐 translated Translation is completed for this page labels Feb 10, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

follow-upChanges applied in a previously translated file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@halian-vilela@fjoshuajr@cezaraugusto