Skip to content

Translate FAQ > File Structure page to pt-BR - #37

Merged
fjoshuajr merged 3 commits into
reactjs:masterfrom
RodolfoSilva:translate-faq-structure
Feb 10, 2019
Merged

Translate FAQ > File Structure page to pt-BR#37
fjoshuajr merged 3 commits into
reactjs:masterfrom
RodolfoSilva:translate-faq-structure

Conversation

@RodolfoSilva

@RodolfoSilvaRodolfoSilva commented Feb 9, 2019

Copy link
Copy Markdown
Contributor

@fjoshuajrfjoshuajr added the needs review A pull request ready to be reviewed label Feb 9, 2019
cezaraugusto
cezaraugusto suggested changes Feb 9, 2019
View reviewed changes

@cezaraugustocezaraugusto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @RodolfoSilva! translation is 100% and no feedback on that.

I guess you updated the links as some translations did previously but we decided to not going this way and keep link sources as-is. I'm sorry for the confusion, could you please change them? I'll approve after that

// not wanted anymore
Existe uma maneira recomendada para estruturar os projetos em React? {#existe-uma-maneira-recomendada-para-estruturar-os-projetos-em-react}

// wanted
Existe uma maneira recomendada para estruturar os projetos em React? {##is-there-a-recommended-way-to-structure-react-projects}

@cezaraugustocezaraugusto added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 9, 2019
@RodolfoSilva

RodolfoSilva commented Feb 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Yes, sure @cezaraugusto 👍 . I'm going to do it now.

@RodolfoSilva

RodolfoSilva commented Feb 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Done @cezaraugusto

cezaraugusto
cezaraugusto previously approved these changes Feb 9, 2019
View reviewed changes

@cezaraugustocezaraugusto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @RodolfoSilva LGTM

@cezaraugustocezaraugusto added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 9, 2019
fjoshuajr
fjoshuajr suggested changes Feb 9, 2019
View reviewed changes

@fjoshuajrfjoshuajr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comments, please.

Comment threadcontent/docs/faq-structure.md Outdated
Comment threadcontent/docs/faq-structure.md Outdated
Comment threadcontent/docs/faq-structure.md Outdated
@fjoshuajrfjoshuajr added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Feb 9, 2019
@RodolfoSilva

RodolfoSilva commented Feb 9, 2019

Copy link
Copy Markdown
ContributorAuthor

@fjoshuajr done!, Thanks 😄

fjoshuajr
fjoshuajr approved these changes Feb 10, 2019
View reviewed changes

@fjoshuajrfjoshuajr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

LGTM 🎉

@fjoshuajr

fjoshuajr commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

thanks @RodolfoSilva LGTM

Ok, will merge this.

@fjoshuajr
fjoshuajr merged commit 41b66dd into reactjs:masterFeb 10, 2019
@tesseralistesseralis mentioned this pull request Feb 10, 2019
Closed
90 tasks
@fjoshuajrfjoshuajr added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input labels Feb 10, 2019
devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@RodolfoSilva@fjoshuajr
TranslateFAQ > File Structurepage to pt-BR (reactjs#37)
2fac5d7
* Translate `FAQ > File Structure` page to pt-BR
* Revert links
* Update faq-structure.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@fjoshuajrfjoshuajrfjoshuajr approved these changes
@cezaraugustocezaraugustocezaraugusto left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🌐 translatedTranslation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RodolfoSilva@fjoshuajr@cezaraugusto