Skip to content

Translating the refs-and-the-dom page - #40

Merged
cezaraugusto merged 13 commits into
reactjs:masterfrom
steniowagner:refs-and-the-dom-translate
Feb 17, 2019
Merged

Translating the refs-and-the-dom page#40
cezaraugusto merged 13 commits into
reactjs:masterfrom
steniowagner:refs-and-the-dom-translate

Conversation

@steniowagner

@steniowagnersteniowagner commented Feb 9, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

#1

Translating the refs-and-the-dom page to PT-BR.

@fjoshuajrfjoshuajr added the needs review A pull request ready to be reviewed label Feb 9, 2019
cezaraugusto
cezaraugusto suggested changes Feb 9, 2019
View reviewed changes

@cezaraugustocezaraugusto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steniowagner wow bold translation here! I left several comments but most of them are related to the change in the link/anchor sources. I know we used this way before but decided to keep them untranslated so I'm sorry for the incovenience.

Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadsrc/components/CodeEditor/CodeEditor.js
Comment threadsrc/components/CodeEditor/CodeEditor.js
Comment threadsrc/components/CodeEditor/CodeEditor.js
@cezaraugustocezaraugusto added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 9, 2019
@steniowagner

steniowagner commented Feb 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Done!

cezaraugusto
cezaraugusto suggested changes Feb 9, 2019
View reviewed changes

@cezaraugustocezaraugusto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you missed some, please change them

Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
@glaucia86

glaucia86 commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

@steniowagner

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

@steniowagner

steniowagner commented Feb 10, 2019

Copy link
Copy Markdown
ContributorAuthor

@glaucia86 how can I change the label?

@WendellAdrielWendellAdriel added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 11, 2019
glaucia86
glaucia86 suggested changes Feb 11, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steniowagner faz as alterações que o @cezaraugusto mencionou a ti (inerente aos códigos)

E capitalize o título do review q te mandei aqui. Assim que fizer essas alterações, estaremos aprovando a sua contribuição. Muito obrigada 😄

Comment threadcontent/docs/refs-and-the-dom.md Outdated
@glaucia86glaucia86 added needs author response Changes requested needing author's input and removed feedback addressed labels Feb 11, 2019
@steniowagner

steniowagner commented Feb 12, 2019

Copy link
Copy Markdown
ContributorAuthor

Acho que agora vai, haha!

Me avisem se algo ainda estiver errado!

@eduardomoronieduardomoroni added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 12, 2019
glaucia86
glaucia86 previously approved these changes Feb 14, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steniowagner

LGTM 👍
Muito obrigada pela sua contribuição!

cc: @cezaraugusto só aprovar. Mais do que revisado. ;)

@glaucia86glaucia86 added needs +1 Needs another approval before merging and removed feedback addressed 💪 long page - more than 100 lines Long page labels Feb 14, 2019
halian-vilela
halian-vilela previously requested changes Feb 15, 2019
View reviewed changes

@halian-vilelahalian-vilela left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bom dia, @steniowagner

Vi que algumas das mudanças na linhas de código solicitadas pelo @cezaraugusto ainda não haviam sido aplicadas.

Adicionei as sugestões aí pois caso o seu editor esteja adicionando-as automaticamente, você consegue commitá-las por aqui.

Também achei alguns pequenos typos que haviam passado batido na revisão anterior.

Fora isso, ótima tradução, só ajustar essas últimas coisinhas aí!

cc:@glaucia86

Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
@halian-vilelahalian-vilela added the needs author response Changes requested needing author's input label Feb 15, 2019
@halian-vilelahalian-vilela removed the needs +1 Needs another approval before merging label Feb 15, 2019
@halian-vilela@steniowagner
Update content/docs/refs-and-the-dom.md
cd12ed8
Co-Authored-By: steniowagner <stenio.wagner1@gmail.com>
@steniowagner
steniowagner dismissed stale reviews from glaucia86 via cd12ed8February 15, 2019 10:59
halian-vilelaand others added 7 commits February 15, 2019 07:59
@halian-vilela@steniowagner
Update content/docs/refs-and-the-dom.md
e10c309
Co-Authored-By: steniowagner <stenio.wagner1@gmail.com>
@halian-vilela@steniowagner
Update content/docs/refs-and-the-dom.md
7a76ec1
Co-Authored-By: steniowagner <stenio.wagner1@gmail.com>
@halian-vilela@steniowagner
Update content/docs/refs-and-the-dom.md
8bab17a
Co-Authored-By: steniowagner <stenio.wagner1@gmail.com>
@halian-vilela@steniowagner
Update content/docs/refs-and-the-dom.md
673bfa6
Co-Authored-By: steniowagner <stenio.wagner1@gmail.com>
@halian-vilela@steniowagner
Update content/docs/refs-and-the-dom.md
ea6fb3d
Co-Authored-By: steniowagner <stenio.wagner1@gmail.com>
@halian-vilela@steniowagner
Update content/docs/refs-and-the-dom.md
a905eb2
Co-Authored-By: steniowagner <stenio.wagner1@gmail.com>
@halian-vilela@steniowagner
Update content/docs/refs-and-the-dom.md
66f4a8c
Co-Authored-By: steniowagner <stenio.wagner1@gmail.com>
@steniowagner

steniowagner commented Feb 15, 2019

Copy link
Copy Markdown
ContributorAuthor

@halian-vilela, acabei comitando tudo por aqui mesmo, como você havia proposto. Achei melhor assim por conta da auto-correção do meu editor.

Obrigado!

cezaraugusto
cezaraugusto approved these changes Feb 17, 2019
View reviewed changes

@cezaraugustocezaraugusto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steniowagner parece otimo, obrigado!

@cezaraugusto

cezaraugusto commented Feb 17, 2019

Copy link
Copy Markdown
Contributor

visto que foi revisado por 3 pessoas e todas as solicitacoes aprovadas, vou aceitar. obrigado!

@cezaraugusto
cezaraugusto merged commit 34d18cc into reactjs:masterFeb 17, 2019
@cezaraugustocezaraugusto added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input labels Feb 17, 2019
@tesseralistesseralis mentioned this pull request Feb 17, 2019
Closed
90 tasks
devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@steniowagner@cezaraugusto
Translating the refs-and-the-dom page (reactjs#40)
fa00a6e
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@cezaraugustocezaraugustocezaraugusto approved these changes
@halian-vilelahalian-vilelahalian-vilela left review comments
@glaucia86glaucia86glaucia86 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@glaucia86glaucia86

@cezaraugustocezaraugusto

Labels

🌐 translatedTranslation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@steniowagner@glaucia86@cezaraugusto@halian-vilela@eduardomoroni@WendellAdriel@fjoshuajr