Skip to content

codebase-overview translate - #43

Merged
glaucia86 merged 9 commits into
reactjs:masterfrom
lamecksilva:master
Feb 11, 2019
Merged

codebase-overview translate#43
glaucia86 merged 9 commits into
reactjs:masterfrom
lamecksilva:master

Conversation

@lamecksilva

@lamecksilvalamecksilva commented Feb 9, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@fjoshuajrfjoshuajr added the needs review A pull request ready to be reviewed label Feb 9, 2019
cezaraugusto
cezaraugusto suggested changes Feb 9, 2019
View reviewed changes

@cezaraugustocezaraugusto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lamecksilva! Lots of work here. I left some comments but overall this looks great!

Comment threadcontent/docs/codebase-overview.md Outdated
Comment threadcontent/docs/codebase-overview.md Outdated
Comment threadcontent/docs/codebase-overview.md Outdated
Comment threadcontent/docs/codebase-overview.md Outdated
Comment threadcontent/docs/codebase-overview.md Outdated
Comment threadcontent/docs/codebase-overview.md Outdated
Comment threadcontent/docs/codebase-overview.md Outdated
Comment threadcontent/docs/codebase-overview.md Outdated
Comment threadcontent/docs/codebase-overview.md Outdated
Comment threadcontent/docs/codebase-overview.md Outdated
@cezaraugustocezaraugusto added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 9, 2019
@lamecksilva

lamecksilva commented Feb 9, 2019

Copy link
Copy Markdown
ContributorAuthor

@cezaraugusto thanks 😉.. i commit again, please check 👍

glaucia86
glaucia86 previously requested changes Feb 10, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lamecksilva
Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

Comment threadcontent/docs/codebase-overview.md Outdated
Comment threadcontent/docs/codebase-overview.md Outdated
Comment threadcontent/docs/codebase-overview.md Outdated
glaucia86and others added 2 commits February 10, 2019 11:08
@glaucia86@lamecksilva
Fix detail 01
4235f28
Co-Authored-By: lamecksilva <31391753+lamecksilva@users.noreply.github.com>
@lamecksilva
Fixing details 2
96f3c28
@lamecksilva

lamecksilva commented Feb 11, 2019

Copy link
Copy Markdown
ContributorAuthor

@glaucia86@cezaraugusto

@fjoshuajrfjoshuajr added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 11, 2019
cezaraugusto
cezaraugusto approved these changes Feb 11, 2019
View reviewed changes

@cezaraugustocezaraugusto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugustocezaraugusto added needs +1 Needs another approval before merging and removed feedback addressed labels Feb 11, 2019
glaucia86
glaucia86 approved these changes Feb 11, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lamecksilva

LGTM 👍 Muito obrigada pela sua contribuição! 😄

@glaucia86
glaucia86 merged commit 4a32463 into reactjs:masterFeb 11, 2019
@tesseralistesseralis mentioned this pull request Feb 11, 2019
Closed
90 tasks
@glaucia86glaucia86 added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Feb 11, 2019
devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@lamecksilva@glaucia86
codebase-overview translate (reactjs#43)
5dfd571
* Adding first translations
* Adding more translation (ultil) colocated tests
* Translating until Flow texts
* More translations...
* 31 lines remaining
* Preparing to pull
* Fixing some details
* Fix detail 01
Co-Authored-By: lamecksilva <31391753+lamecksilva@users.noreply.github.com>
* Fixing details 2
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@glaucia86glaucia86glaucia86 approved these changes
@cezaraugustocezaraugustocezaraugusto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🌐 translatedTranslation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lamecksilva@glaucia86@cezaraugusto@fjoshuajr